-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CEL tests to TestGrid Dashboard #13287
Conversation
Welcome @victoriajyang! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @victoriajyang. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I have CLA access now |
/assign @spiffxp |
/ok-to-test |
testgrid/config.yaml
Outdated
url: https://github.com/google/cel-go | ||
results_text: See these results on Google Cloud Storage # Text to show in the about menu as a link to another view of the results | ||
results_url_template: # The URL template to visit after clicking | ||
url: https://pantheon.corp.google.com/storage/browser/cel-conformance/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a non-corp.google.com
URI
Please squash down to a single commit now that you've got tests happy |
It is not entirely clear to me how these changes relate to Kubernetes? |
/hold |
Originally I was going to make our own TestGrid instance but @michelle192837 said I could add it to the existing one. |
Yup, the current policy I believe is if you're okay with your results being public and on the K8s TestGrid, then feel free to add your results here. |
fix config fix underscore
/lgtm But leaving the hold on for @spiffxp's opinion. |
LGTM label has been added. Git tree hash: 1a1ebf1c98325396fe1ca21262c2765a2b159db7
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp, victoriajyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, it shouldn't be the case forever, but for now think this is the best we've got. Consider it blocked on #10409; it's this or some impossible/really expensive work. |
Add CEL conformance tests to TestGrid dashboard