Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI jobs for 1.15 and only have alpha jobs for 1.15 and master #13434

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Jul 12, 2019

This should allow us to update prow in external-snapshotter

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 12, 2019
@k8s-ci-robot k8s-ci-robot requested review from ixdy and pohly July 12, 2019 22:00
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@msau42
Copy link
Member Author

msau42 commented Jul 12, 2019

/assign @pohly @jsafrane

@msau42 msau42 force-pushed the add-1.15-csi-jobs branch from 737497f to c0f7558 Compare July 15, 2019 16:23
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 923e749345dd85f5c8a713580e57c0d13b21e339

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0e68a1e into kubernetes:master Jul 15, 2019
@k8s-ci-robot
Copy link
Contributor

@msau42: Updated the job-config configmap in namespace default using the following files:

  • key csi-driver-host-path-config.yaml using file config/jobs/kubernetes-csi/csi-driver-host-path/csi-driver-host-path-config.yaml
  • key external-attacher-config.yaml using file config/jobs/kubernetes-csi/external-attacher/external-attacher-config.yaml
  • key external-provisioner-config.yaml using file config/jobs/kubernetes-csi/external-provisioner/external-provisioner-config.yaml
  • key external-snapshotter-config.yaml using file config/jobs/kubernetes-csi/external-snapshotter/external-snapshotter-config.yaml
  • key livenessprobe-config.yaml using file config/jobs/kubernetes-csi/livenessprobe/livenessprobe-config.yaml
  • key node-driver-registrar-config.yaml using file config/jobs/kubernetes-csi/node-driver-registrar/node-driver-registrar-config.yaml

In response to this:

This should allow us to update prow in external-snapshotter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pohly added a commit to pohly/test-infra that referenced this pull request Sep 18, 2019
…etes repos

The original intention was to let repos which only need to be tested
against a single Kubernetes release choose that release
themselves. The comment for `single_kubernetes_repos` still describes
that behavior.

kubernetes#13434 changed that so
that 1.15 is used for all of these repos because of some issues with
external-snapshotter.

external-snapshotter now has 1.15 in its own prow.sh, so we don't need
the override anymore in the test job and can revert to the original
behavior.
pohly added a commit to pohly/test-infra that referenced this pull request Sep 23, 2019
…etes repos

The original intention was to let repos which only need to be tested
against a single Kubernetes release choose that release
themselves. The comment for `single_kubernetes_repos` still describes
that behavior.

kubernetes#13434 changed that so
that 1.15 is used for all of these repos because of some issues with
external-snapshotter.

external-snapshotter now has 1.15 in its own prow.sh, so we don't need
the override anymore in the test job and can revert to the original
behavior.
pohly added a commit to pohly/test-infra that referenced this pull request Sep 23, 2019
…etes repos

The original intention was to let repos which only need to be tested
against a single Kubernetes release choose that release
themselves. The comment for `single_kubernetes_repos` still describes
that behavior.

kubernetes#13434 changed that so
that 1.15 is used for all of these repos because of some issues with
external-snapshotter.

external-snapshotter now has 1.15 in its own prow.sh, so we don't need
the override anymore in the test job and can revert to the original
behavior.
pohly added a commit to pohly/test-infra that referenced this pull request Sep 23, 2019
…etes repos

The original intention was to let repos which only need to be tested
against a single Kubernetes release choose that release
themselves. The comment for `single_kubernetes_repos` still describes
that behavior.

kubernetes#13434 changed that so
that 1.15 is used for all of these repos because of some issues with
external-snapshotter.

external-snapshotter now has 1.15 in its own prow.sh, so we don't need
the override anymore in the test job and can revert to the original
behavior.
pohly added a commit to pohly/test-infra that referenced this pull request Sep 23, 2019
…etes repos

The original intention was to let repos which only need to be tested
against a single Kubernetes release choose that release
themselves. The comment for `single_kubernetes_repos` still describes
that behavior.

kubernetes#13434 changed that so
that 1.15 is used for all of these repos because of some issues with
external-snapshotter.

external-snapshotter now has 1.15 in its own prow.sh, so we don't need
the override anymore in the test job and can revert to the original
behavior.
pohly added a commit to pohly/test-infra that referenced this pull request Oct 1, 2019
…etes repos

The original intention was to let repos which only need to be tested
against a single Kubernetes release choose that release
themselves. The comment for `single_kubernetes_repos` still describes
that behavior.

kubernetes#13434 changed that so
that 1.15 is used for all of these repos because of some issues with
external-snapshotter.

external-snapshotter now has 1.15 in its own prow.sh, so we don't need
the override anymore in the test job and can revert to the original
behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants