-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete vendor from test-infra #14036
Conversation
LGTM label has been added. Git tree hash: 9106daec5e8afb3dcd7a50f7a67c2a0f8a994c0e
|
/hold |
Now with passing tests! |
LGTM label has been added. Git tree hash: 2ea2d6d093e22032ed33bdbaffc4dd360535af2f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this have any impact on downstream repositories importing Prow types, etc? |
Is there a specific scenario you're concerned about? This should not have a downstream impact as they can use our go.mod to create a correct version of vendor or go.mod for their repo. |
Generally importing |
Definitely won't make things worse, may make things better. |
/hold cancel |
Go modules no longer uses this directory, and bazel is more efficient without it.
@com_github_foo_bar//whatever
instead of//vendor/github.com/foo/bar/whatever
/assign @Katharine @stevekuznetsov @michelle192837