Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable boskos in k8s.io/perf-test presubmits #14725

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Enable boskos in k8s.io/perf-test presubmits #14725

merged 1 commit into from
Oct 11, 2019

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Oct 11, 2019

Boskos issues were fixed in #14697. Let's try re-enabling.

Ref. kubernetes/perf-tests#650

@mm4tt
Enable boskos in k8s.io/perf-test presubmits
84ae9e5 
Boskos issues were fixed in
kubernetes#14697.
Let's try re-enabling.

Ref. kubernetes/perf-tests#650
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2019
@mborsz
Copy link
Member

mborsz commented Oct 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 11, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, mm4tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7ae11e5 into kubernetes:master Oct 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

@mm4tt: Updated the job-config configmap in namespace default using the following files:

  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml

In response to this:

Boskos issues were fixed in #14697. Let's try re-enabling.

Ref. kubernetes/perf-tests#650

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@mborsz mborsz Awaiting requested review from mborsz

Assignees

@mborsz mborsz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
3 participants
@mm4tt @mborsz @k8s-ci-robot