Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prow job config for pushing cloud provider azure image to gcr staing repo. #15545

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Add prow job config for pushing cloud provider azure image to gcr staing repo. #15545

merged 1 commit into from
Dec 10, 2019

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Dec 10, 2019

Add prow job config for pushing cloud provider azure image to gcr staing repo.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2019
@nilo19 nilo19 mentioned this pull request Dec 10, 2019
Merged
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2019
@nilo19 nilo19 force-pushed the qi-add-staging-gcr-job branch 3 times, most recently from fd684f5 to 9129f58 Compare December 10, 2019 06:40
feiskyer
feiskyer reviewed Dec 10, 2019
View reviewed changes
config/jobs/image-pushing/k8s-staging-provider-azure.yaml Outdated
postsubmits:
# This is the github repo we'll build from. This block needs to be repeated
# for each repo.
kubernetes-sigs/some-repo-name:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes-sigs/cloud-provider-azure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@nilo19 nilo19 force-pushed the qi-add-staging-gcr-job branch from 9129f58 to 8a50c50 Compare December 10, 2019 07:07
feiskyer
feiskyer reviewed Dec 10, 2019
View reviewed changes
config/jobs/image-pushing/k8s-staging-provider-azure.yaml Outdated
annotations:
# This is the name of some testgrid dashboard to report to.
# If this is the first one for your sig, you may need to create one
testgrid-dashboards: sig-cloud-provider-image-pushes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer here

test-infra/config/testgrids/kubernetes/sig-cloud-provider/azure/config.yaml

Line 1 in 9bcc9e7

dashboard_groups:
to add a dashboard

@nilo19 nilo19 force-pushed the qi-add-staging-gcr-job branch from 8a50c50 to 80e5db8 Compare December 10, 2019 08:37
feiskyer
feiskyer reviewed Dec 10, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2019
@feiskyer
Copy link
Member

/assign @BenTheElder

@BenTheElder
Copy link
Member

not overly familiar with the new image push tooling but this looks about right
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9170073 into kubernetes:master Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 10, 2019
@k8s-ci-robot
Copy link
Contributor

@nilo19: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-provider-azure.yaml using file config/jobs/image-pushing/k8s-staging-provider-azure.yaml

In response to this:

Add prow job config for pushing cloud provider azure image to gcr staing repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nilo19 nilo19 deleted the qi-add-staging-gcr-job branch December 11, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@Katharine Katharine Awaiting requested review from Katharine

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@feiskyer feiskyer

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@nilo19 @feiskyer @BenTheElder @k8s-ci-robot