Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Enable building kubepkg image and fix commands for deb/rpm jobs #15871

Merged
merged 1 commit into from
Jan 13, 2020
Merged

releng: Enable building kubepkg image and fix commands for deb/rpm jobs #15871

merged 1 commit into from
Jan 13, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jan 12, 2020 •
edited
Loading

Companion PR to kubernetes/release#1011.
Fixes: kubernetes/kubernetes#86965, kubernetes/kubernetes#87141 (cc: @kubernetes/ci-signal)

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @hoegaarden @saschagrunert @cpanato
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 12, 2020
This was referenced Jan 12, 2020
Merged
Closed
@justaugustus
Copy link
Member Author

/assign @Katharine @michelle192837

@justaugustus
Copy link
Member Author

/test pull-test-infra-bazel

saschagrunert
saschagrunert approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2020
@justaugustus
releng: Enable building kubepkg image and fix commands for deb/rpm jobs
5f35e85 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2020
cpanato
cpanato approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2020
saschagrunert
saschagrunert approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus justaugustus mentioned this pull request Jan 13, 2020
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, Katharine, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2338cc3 into kubernetes:master Jan 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 13, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-release-test.yaml using file config/jobs/image-pushing/k8s-staging-release-test.yaml
  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml

In response to this:

Companion PR to kubernetes/release#1011.
Fixes: kubernetes/kubernetes#86965, kubernetes/kubernetes#87141 (cc: @kubernetes/ci-signal)

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @hoegaarden @saschagrunert @cpanato
cc: @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus mentioned this pull request Jan 19, 2020
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@Katharine Katharine Katharine approved these changes

Assignees

@Katharine Katharine

@michelle192837 michelle192837

@saschagrunert saschagrunert

@hoegaarden hoegaarden

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

[Failing Test] build-packages-rpms (ci-release-build-packages-rpms)
7 participants
@justaugustus @k8s-ci-robot @Katharine @saschagrunert @cpanato @michelle192837 @hoegaarden