Refactor Boskos directory structure

[ixdy]

The Boskos directory had main packages mixed in with library packages. I've refactored most of the main methods into a cmd/ subdirectory, similar to what is done with Prow. (I have not touched the aws-janitor, at least not yet, because it has its own internal structure.)

Besides making everything a bit easier to maintain and understand, this is a precursor to some additional things I'm working on:

• I want to add metrics to the janitors (monitor boskos cleanup timing #14715), including the AWS janitor, but the existing structure didn't offer a good place to put common code.
• I want to simplify how core resource metrics are exposed (boskos: merge Prometheus resource metrics into boskos core #16001), but again, there's no good place to refactor the metrics currently.

/assign @stevekuznetsov @sebastienvas @krzyzacy

[krzyzacy]

do we also want to shuffle mason around?

/lgtm
/hold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• boskos/OWNERS [krzyzacy]
• config/OWNERS [krzyzacy]
• scenarios/OWNERS [krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ixdy]

@krzyzacy thanks for the fast review!

I'm not sure what else there is to be done with mason right now.

I moved the fake-mason command into cmd, and what remains is just the interface that implementations implement.

The actual GCP implementation still lives in istio/test-infra (https://github.com/istio/test-infra/tree/master/boskos). I'm not sure why it wasn't moved along with the mason interface - maybe @sebastienvas or @chases2 knows.

[ixdy]

/hold cancel

Rebased. Can I get a re-LGTM before things change again?

[krzyzacy]

/lgtm

[stevekuznetsov]

cc @alvaroaleman

[k8s-ci-robot]

@ixdy: Updated the job-config configmap in namespace default at cluster default using the following files:

• key janitors.yaml using file config/jobs/kubernetes/test-infra/janitors.yaml

In response to this:

The Boskos directory had main packages mixed in with library packages. I've refactored most of the main methods into a cmd/ subdirectory, similar to what is done with Prow. (I have not touched the aws-janitor, at least not yet, because it has its own internal structure.)

Besides making everything a bit easier to maintain and understand, this is a precursor to some additional things I'm working on:

• I want to add metrics to the janitors (monitor boskos cleanup timing #14715), including the AWS janitor, but the existing structure didn't offer a good place to put common code.
• I want to simplify how core resource metrics are exposed (boskos: merge Prometheus resource metrics into boskos core #16001), but again, there's no good place to refactor the metrics currently.

/assign @stevekuznetsov @sebastienvas @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.