Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presubmits for perf-tests release branches #16248

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Add presubmits for perf-tests release branches #16248

merged 1 commit into from
Feb 17, 2020

Conversation

jkaniuk
Copy link
Contributor

@jkaniuk jkaniuk commented Feb 12, 2020 •
edited
Loading

Add presubmits to all release branches of perf-tests repository:

  • pull-perf-tests-clusterloader2
  • pull-perf-tests-clusterloader2-kubemark

/cc wojtek-t

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 12, 2020
wojtek-t
wojtek-t reviewed Feb 14, 2020
View reviewed changes
config/jobs/kubernetes/sig-release/release-branch-jobs/1.14.yaml
branches:
- release-1.14
labels:
preset-bazel-scratch-dir: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always wondering how do we end-up with different presets order in different jobs - I'm comparing with the regular presubmit and there is different preset order and different order of options too...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config-forker creates newest job (in the future - 1.18) based on our manually curated source yamls. That forked yaml will be alphabetically sorted.
Later on, we do modify 1.14-1.18 yamls in place making various adjustments (or adding new jobs to them) - those will be manually ordered again.
I've generated changes for this PR using config-forker, that is why it is alphabetical here, but not in sig-scalability-presubmit-jobs.yaml.

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaniuk, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2020
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Feb 14, 2020

/cc justaugustus

I plan to merge it next week after last check of weekend runs:
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2020
@justaugustus
Copy link
Member

I plan to merge it next week after last check of weekend runs:
/hold

SGTM! LGTM, but I'll wait until next week to approve.

@jkaniuk
Copy link
Contributor Author

jkaniuk commented Feb 17, 2020

Last runs for all tests are green.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 73cc13b into kubernetes:master Feb 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

@jkaniuk: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key 1.14.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.14.yaml
  • key 1.15.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.15.yaml
  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml

In response to this:

Add presubmits to all release branches of perf-tests repository:

  • pull-perf-tests-clusterloader2
  • pull-perf-tests-clusterloader2-kubemark

/cc wojtek-t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

/lgtm
/approve

@mm4tt mm4tt mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@jkaniuk @wojtek-t @k8s-ci-robot @justaugustus