Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add presubmits for perf-tests release branches" #16360

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Revert "Add presubmits for perf-tests release branches" #16360

merged 1 commit into from
Feb 19, 2020

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Feb 19, 2020

This reverts commit dfcf87c.

We think it may be a root cause for #14697

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2020
@mborsz
Copy link
Member Author

mborsz commented Feb 19, 2020

/assign @mm4tt

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 19, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Feb 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2020
@mborsz
Copy link
Member Author

mborsz commented Feb 19, 2020

/assign @wojtek-t

@mborsz
Copy link
Member Author

mborsz commented Feb 19, 2020

/assign @fejta

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, mborsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit d0e214d into kubernetes:master Feb 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

@mborsz: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key 1.15.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.15.yaml
  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml

In response to this:

This reverts commit dfcf87c.

We think it may be a root cause for #14697

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jprzychodzen jprzychodzen mentioned this pull request Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@chases2 chases2 Awaiting requested review from chases2

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@fejta fejta

@mm4tt mm4tt

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@mborsz @mm4tt @k8s-ci-robot @fejta @wojtek-t