Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: pin ci-kubernetes-node-e2e-kubelet to spare project #17251

Merged
merged 1 commit into from
Apr 17, 2020
Merged

jobs: pin ci-kubernetes-node-e2e-kubelet to spare project #17251

merged 1 commit into from
Apr 17, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Apr 17, 2020

so we know it can work with boskos managed projects, but until we get
a pool set aside for node jobs, I'd rather prevent them from using
the pool used by most e2e jobs, in case a network ban happens again

/cc @dims

@spiffxp
jobs: pin ci-kubernetes-node-e2e-kubelet to spare project
814089f 
so we know it can work with boskos managed projects, but until we get
a pool set aside for node jobs, I'd rather prevent them from using
the pool used by most e2e jobs, in case a network ban happens again
@k8s-ci-robot k8s-ci-robot requested a review from dims April 17, 2020 00:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 17, 2020
@BenTheElder
Copy link
Member

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Apr 17, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Apr 17, 2020

/retest

@dims
Copy link
Member

dims commented Apr 17, 2020

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c52d78c into kubernetes:master Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 17, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

so we know it can work with boskos managed projects, but until we get
a pool set aside for node jobs, I'd rather prevent them from using
the pool used by most e2e jobs, in case a network ban happens again

/cc @dims

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the pin-ci-node-kubelet-to-spare-project branch April 17, 2020 01:08
@spiffxp spiffxp mentioned this pull request Apr 17, 2020
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Apr 17, 2020

ref: kubernetes/kubernetes#89892 (comment)

hasheddan added a commit to hasheddan/test-infra that referenced this pull request Apr 17, 2020
@hasheddan
jobs: pin release-informing node jobs away from k8s-jkns-ci-node-e2e
4980ce7 
release-blocking jobs were already moved to a different GCP
project in kubernetes#17251 and kubernetes#17257 due to network issues. This
also moves the release-informing jobs away until new GCP
project is created (ref: kubernetes/kubernetes#89892 (comment)).

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @BenTheElder @dims @k8s-ci-robot