Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boskos-resources: shrink gke-project pool #17279

Merged
merged 1 commit into from
Apr 17, 2020
Merged

boskos-resources: shrink gke-project pool #17279

merged 1 commit into from
Apr 17, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Apr 17, 2020

this pool is now wildly overprovisioned, I'd like to use some of it
to create some smaller canary pools

@spiffxp
boskos-resources: shrink gke-project pool
e81cc02 
this pool is now wildly overprovisioned, I'd like to use some of it
to create some smaller canary pools
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2020
@k8s-ci-robot k8s-ci-robot requested review from ixdy and krzyzacy April 17, 2020 21:00
@k8s-ci-robot k8s-ci-robot added area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ixdy
Copy link
Member

ixdy commented Apr 17, 2020

/lgtm

If these are in-use, they may not actually be deleted, and may require manual cleanup (i.e. deletion) from the oncall.

@k8s-ci-robot k8s-ci-robot merged commit a6017ee into kubernetes:master Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 17, 2020
@ixdy
Copy link
Member

ixdy commented Apr 17, 2020

#17282 for the issue I described.

@spiffxp spiffxp deleted the shrink-gke-project-pool branch April 17, 2020 21:24
@spiffxp
Copy link
Member Author

spiffxp commented Apr 17, 2020

Looks like they were deleted, no gke-project resources

$ k get resources -n test-pods | grep k8s-jkns-gke
k8s-jkns-gke-reboot-1-4          gce-project                     free                                                                               17m
k8s-jkns-gke-slow-1-4            gce-project                     free

@spiffxp spiffxp mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy approved these changes

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@krzyzacy krzyzacy

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @k8s-ci-robot @ixdy @krzyzacy