Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use instance template on boskos-http dashboard #17525

Merged
merged 1 commit into from
May 6, 2020
Merged

Use instance template on boskos-http dashboard #17525

merged 1 commit into from
May 6, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented May 6, 2020

Whoops, I missed the part where the template needs to actually
be used in queries

Followup to: #17524

@spiffxp
Use instance template on boskos-http dashboard
d25b42d 
Whoops, I missed the part where the template needs to actually
be used in queries
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 6, 2020
@spiffxp spiffxp mentioned this pull request May 6, 2020
Merged
hasheddan
hasheddan approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3d4480a into kubernetes:master May 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 6, 2020
@spiffxp spiffxp deleted the boskos-server-dashboard-instances-pt2 branch May 21, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan