Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ingress-nginx push image postsubmit job #17652

Merged
merged 1 commit into from
May 28, 2020
Merged

Add ingress-nginx push image postsubmit job #17652

merged 1 commit into from
May 28, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 20, 2020

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2020
@aledbf
Copy link
Member Author

aledbf commented May 20, 2020

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from clarketm and spiffxp May 20, 2020 12:53
@aledbf
Copy link
Member Author

aledbf commented May 27, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 822ccd5 into kubernetes:master May 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 28, 2020
@k8s-ci-robot
Copy link
Contributor

@aledbf: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-ingress-nginx.yaml using file config/jobs/image-pushing/k8s-staging-ingress-nginx.yaml

In response to this:

xref: kubernetes/k8s.io#882

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 28, 2020
Closed
Closed
@aledbf aledbf deleted the push branch June 3, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarketm clarketm Awaiting requested review from clarketm

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @BenTheElder @k8s-ci-robot