-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop publishing latest-green.txt and migrate to k8s-infra-prow-build #17672
Conversation
This migrates ci-kubernetes-e2e-gci-gce over to the k8s-infra owned prow build cluster. The release branch variants of this job have already been moved over. What was preventing this from moving over was the --publish flag, implying that this job needed write access to a bucket that won't allow non-google.com access. I have looked using cs.k8s.io and can't find any code that actually relies on the existence of latest-green.txt. I could have sworn that it was at one time used by tooling in kubernetes/release (eg: as part of find_green_build), but I haven't found it in history there either. I've looked in this repo's history, and publishing to this path has been present since inception, but I still can't find what might actually be looking for this file. It's referenced in docs in a few places, which I will PR to remove if those are the only references.
/hold |
/lgtm Let's do this! |
For releng, we rely on which is produced from the There are minimal references to latest-green, so I'm in favor of finally removing it. /lgtm Feel free to pull the hold at will. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Two places that come to mind where it may have been used at some point in the distant past:
|
The latest-green.txt file was added in 2015: kubernetes/kubernetes#10428 Amusingly, there was a recent comment about it: kubernetes/kubernetes#10410 (comment) |
Also, I may have been thinking about kops' use of https://storage.googleapis.com/kops-ci/bin/latest-ci-updown-green.txt. |
/hold cancel |
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This migrates ci-kubernetes-e2e-gci-gce over to the k8s-infra owned
prow build cluster. The release branch variants of this job have
already been moved over. What was preventing this from moving over
was the --publish flag, implying that this job needed write access
to a bucket that won't allow non-google.com access.
I have looked using cs.k8s.io and can't find any code that actually
relies on the existence of latest-green.txt. I could have sworn that
it was at one time used by tooling in kubernetes/release (eg: as part
of find_green_build), but I haven't found it in history there either.
I've looked in this repo's history, and publishing to this path has
been present since inception, but I still can't find what might actually
be looking for this file.
It's referenced in docs in a few places, which I will PR to remove if
those are the only references.
/cc @fejta @ixdy
maybe you remember the history of this file?