Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pull-kubernetes-e2e-kind to k8s-infra-prow-build #18817

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Migrate pull-kubernetes-e2e-kind to k8s-infra-prow-build #18817

merged 1 commit into from
Aug 13, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 13, 2020 •
edited
Loading

Migrate pull-kubernetes-e2e-kind to give more visibility to the community
about resources consumption.

Ref: #18812

Signed-off-by: Arnaud Meukam ameukam@gmail.com

/assign @spiffxp @BenTheElder @hasheddan

@ameukam
Migrate pull-kubernetes-e2e-kind to k8s-infra-prow-build
005e7aa 
Migrate pull-kubernetes-e2e-kind to give more visibility to community
about resources consumption.

Ref: kubernetes#18812

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 13, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 13, 2020
spiffxp
spiffxp approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

I hadn't noticed this before I opened #18825, this catches the release branches (which I did not) but misses making the release and main branch values consistent. I'll rebase my PR to address

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
This was referenced Aug 13, 2020
Closed
Merged
@k8s-ci-robot k8s-ci-robot merged commit de4e363 into kubernetes:master Aug 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 13, 2020
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml
  • key kubernetes-kind-presubmits.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml

In response to this:

Migrate pull-kubernetes-e2e-kind to give more visibility to the community
about resources consumption.

Ref: #18812

Signed-off-by: Arnaud Meukam ameukam@gmail.com

/assign @spiffxp @BenTheElder @hasheddan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam ameukam mentioned this pull request Aug 13, 2020
Closed
@ameukam ameukam deleted the pull-k8s-e2e-kind-to-k8s-infra-prow-build branch March 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@spiffxp spiffxp

@BenTheElder BenTheElder

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@ameukam @k8s-ci-robot @spiffxp @BenTheElder @hasheddan