Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pull-kubernetes-node-e2e to k8s-infra-prow-build #18915

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Migrate pull-kubernetes-node-e2e to k8s-infra-prow-build #18915

merged 1 commit into from
Aug 19, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 19, 2020

Drop the use of k8s-jkns-pr-node-e2e, which means the jobs will
instead use the gce-project pool from boskos, which is the same
pool used by the ci equivalent of this job.

Part of #18851

@spiffxp
Migrate pull-kubernetes-node-e2e to k8s-infra-prow-build
fd26849 
Drop the use of k8s-jkns-pr-node-e2e, which means the jobs will
instead use the gce-project pool from boskos, which is the same
pool used by the ci equivalent of this job.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/node Categorizes an issue or PR as relevant to SIG Node. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 19, 2020
@spiffxp spiffxp mentioned this pull request Aug 19, 2020
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Aug 19, 2020

/cc @BenTheElder
FYI @SergeyKanzhelev @vpickard @kubernetes/ci-signal

hasheddan
hasheddan approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1f02f84 into kubernetes:master Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml

In response to this:

Drop the use of k8s-jkns-pr-node-e2e, which means the jobs will
instead use the gce-project pool from boskos, which is the same
pool used by the ci equivalent of this job.

Part of #18851

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the migrate-pull-node-e2e-to-k8s-infra-prow-build branch August 19, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@justaugustus justaugustus Awaiting requested review from justaugustus

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan