-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a schema for the ProwJob crd #19522
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d285893
Add CRD generation
alvaroaleman e1e8d70
Update tektoncd to a version with json tags
alvaroaleman 9c75bf5
Broken CRD
alvaroaleman 4de7ba1
Add marker
alvaroaleman 978c4ee
Update controller-runtime to latest head
alvaroaleman d952412
Use generated crd in integation tests
alvaroaleman acba56b
Remove incorrect third copy of crd
alvaroaleman 69a7027
SSA can not default the port?
alvaroaleman 491a322
Protocols for everyone
alvaroaleman 24c2a4c
Remove go 1.17 header
alvaroaleman dda496a
Link the crd instead of duplicating it
alvaroaleman 02565dd
Update getting started docs
alvaroaleman 5328b15
Remove stale copyfiles
alvaroaleman 5fa7390
Re-Add validation that completionTime must be set
alvaroaleman e597c6e
Apply ProwJob crd with --server-side=true
alvaroaleman ed7b897
Add announcement and schemaless manifest as fallback
alvaroaleman e773593
Args is a list
alvaroaleman 429fc65
Must specify protocol
alvaroaleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,5 +9,6 @@ spec: | |
| ports: | ||
| - name: metrics | ||
| port: 9090 | ||
| protocol: TCP | ||
| selector: | ||
| app: crier | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,8 @@ spec: | |
| ports: | ||
| - name: main | ||
| port: 8888 | ||
| protocol: TCP | ||
| - name: metrics | ||
| port: 9090 | ||
| protocol: TCP | ||
| type: NodePort | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,5 +9,6 @@ spec: | |
| ports: | ||
| - name: metrics | ||
| port: 9090 | ||
| protocol: TCP | ||
| selector: | ||
| app: horologium | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,5 +23,6 @@ spec: | |
| ports: | ||
| - name: metrics | ||
| port: 9090 | ||
| protocol: TCP | ||
| selector: | ||
| app: prow-controller-manager | ||
20,130 changes: 20,066 additions & 64 deletions
20,130
config/prow/cluster/prowjob_customresourcedefinition.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
95 changes: 95 additions & 0 deletions
95
config/prow/cluster/prowjob_customresourcedefinition_schemaless.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| name: prowjobs.prow.k8s.io | ||
| annotations: | ||
| "api-approved.kubernetes.io": "https://github.com/kubernetes/test-infra/pull/8669" | ||
| spec: | ||
| group: prow.k8s.io | ||
| names: | ||
| kind: ProwJob | ||
| singular: prowjob | ||
| plural: prowjobs | ||
| scope: Namespaced | ||
| versions: | ||
| - name: v1 | ||
| served: true | ||
| storage: true | ||
| schema: | ||
| openAPIV3Schema: | ||
| type: object | ||
| properties: | ||
| spec: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| properties: | ||
| max_concurrency: | ||
| type: integer | ||
| minimum: 0 | ||
| type: | ||
| type: string | ||
| enum: | ||
| - "presubmit" | ||
| - "postsubmit" | ||
| - "periodic" | ||
| - "batch" | ||
| status: | ||
| type: object | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| properties: | ||
| state: | ||
| type: string | ||
| enum: | ||
| - "triggered" | ||
| - "pending" | ||
| - "success" | ||
| - "failure" | ||
| - "aborted" | ||
| - "error" | ||
| anyOf: | ||
| - not: | ||
| properties: | ||
| state: | ||
| enum: | ||
| - "success" | ||
| - "failure" | ||
| - "error" | ||
| - required: | ||
| - completionTime | ||
| additionalPrinterColumns: | ||
| - name: Job | ||
| type: string | ||
| description: The name of the job being run. | ||
| jsonPath: .spec.job | ||
| - name: BuildId | ||
| type: string | ||
| description: The ID of the job being run. | ||
| jsonPath: .status.build_id | ||
| - name: Type | ||
| type: string | ||
| description: The type of job being run. | ||
| jsonPath: .spec.type | ||
| - name: Org | ||
| type: string | ||
| description: The org for which the job is running. | ||
| jsonPath: .spec.refs.org | ||
| - name: Repo | ||
| type: string | ||
| description: The repo for which the job is running. | ||
| jsonPath: .spec.refs.repo | ||
| - name: Pulls | ||
| type: string | ||
| description: The pulls for which the job is running. | ||
| jsonPath: ".spec.refs.pulls[*].number" | ||
| - name: StartTime | ||
| type: date | ||
| description: When the job started running. | ||
| jsonPath: .status.startTime | ||
| - name: CompletionTime | ||
| type: date | ||
| description: When the job finished running. | ||
| jsonPath: .status.completionTime | ||
| - name: State | ||
| description: The state of the job. | ||
| type: string | ||
| jsonPath: .status.state |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we're just speculating that this will work, but not sure. might suggest move this change to a separate PR just in case revert is needed we don't need to revert this large PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, not doing this will definitely not work as the PR changes the CRD file 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, finger crossed then