Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep kubernetes/k8s.io for default branch rename #20675

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Prep kubernetes/k8s.io for default branch rename #20675

merged 1 commit into from
Feb 8, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 29, 2021

Part of kubernetes/k8s.io#1597

/hold
The periodic changes here are disruptive, they will break until the branch is renamed. Will remove the hold when it's not late on a friday.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Jan 29, 2021
@spiffxp spiffxp force-pushed the pre-k-k8s-branch-rename branch from 517e28e to d061d9c Compare January 29, 2021 22:54
@spiffxp spiffxp mentioned this pull request Jan 29, 2021
Closed
saschagrunert
saschagrunert approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Feb 8, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 76ffa49 into kubernetes:master Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the following 2 configmaps:

  • plugins configmap in namespace default at cluster test-infra-trusted using the following files:
    • key plugins.yaml using file config/prow/plugins.yaml
  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key k8s-staging-infra-tools.yaml using file config/jobs/image-pushing/k8s-staging-infra-tools.yaml
    • key container-image-promoter.yaml using file config/jobs/kubernetes/sig-release/cip/container-image-promoter.yaml
    • key k8sio-presubmit.yaml using file config/jobs/kubernetes/wg-k8s-infra/k8sio-presubmit.yaml
    • key releng-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/releng/releng-trusted.yaml
    • key wg-k8s-infra-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-trusted.yaml

In response to this:

Part of kubernetes/k8s.io#1597

/hold
The periodic changes here are disruptive, they will break until the branch is renamed. Will remove the hold when it's not late on a friday.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the pre-k-k8s-branch-rename branch February 9, 2021 00:34
@nikhita nikhita mentioned this pull request Mar 7, 2021
Merged
@BenTheElder BenTheElder mentioned this pull request Mar 11, 2021
Closed
20 tasks
@spiffxp spiffxp mentioned this pull request Apr 1, 2021
Closed
16 tasks
@christopherhein christopherhein mentioned this pull request May 6, 2021
Closed
13 tasks
@ArangoGutierrez ArangoGutierrez mentioned this pull request Aug 10, 2021
Closed
20 tasks
@CecileRobertMichon CecileRobertMichon mentioned this pull request Aug 13, 2021
Closed
19 tasks
@aramase aramase mentioned this pull request Aug 17, 2021
Closed
19 tasks
@mrueg mrueg mentioned this pull request Aug 23, 2021
Closed
19 tasks
@justaugustus justaugustus mentioned this pull request Sep 13, 2021
Closed
28 tasks
@CecileRobertMichon CecileRobertMichon mentioned this pull request Sep 20, 2021
Closed
@tobiasgiese tobiasgiese mentioned this pull request Sep 24, 2021
Closed
This was referenced Oct 6, 2021
Closed
Closed
@cpanato cpanato mentioned this pull request Oct 11, 2021
Open
18 tasks
This was referenced Nov 3, 2021
Closed
Closed
Closed
Closed
Closed
@cpanato cpanato mentioned this pull request Dec 13, 2021
Open
19 tasks
@sbueringer sbueringer mentioned this pull request Feb 12, 2023
Closed
@AverageMarcus AverageMarcus mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@dims dims Awaiting requested review from dims

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @saschagrunert