-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reconcile kubernetes/kubernetes stableN version markers #20887
reconcile kubernetes/kubernetes stableN version markers #20887
Conversation
a101115
to
3140fd9
Compare
Needed to rebase due to #20880 merging |
3140fd9
to
fbef234
Compare
fbef234
to
be80338
Compare
be80338
to
acf5550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addresses #19922 (comment)
When the
gs://k8s-release-dev/ci/k8s-stableN.txt' version markers were rolled forward, the equivalents in
gs://kubernetes-release-dev` were missed.The config for auto-generated release jobs in
releng/
was also missed, so somestable1
jobs were pointed atv1.19
(two releases ago instead of 1)No longer WIP now that:
I haven't verified whether the stableN job names match up properly, and confirmed everything on a given release-1.y-blocking testgrid dashboard actually uses release-1.ylgtmThis contains commits from Log or enforce kubernetes jobs pull from k8s-infra buckets #20885, I'll rebase once that mergesrebasedWhat I consider out of scope for this PR, but am open to for followup:
I'm less certain we can drop populating the
ci/k8s-stableN
version markers without a deprecation window