-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes-ci-images => k8s-staging-ci-images #21548
kubernetes-ci-images => k8s-staging-ci-images #21548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
These are deprecated build jobs, but probably good to go ahead and move them over as well. Thanks @BobyMCbobs!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BobyMCbobs, hasheddan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Oh just realized these are to hold over until the switch is complete. Thanks @justaugustus ! |
I wonder if it would make sense to remove this job with the release of a new version (e.g. v1.21) so that consumers will break when they consume a new version of k8s. This wouldn't really make a difference for folks consuming version markers, but it would provide a tangible cut-off at which support was dropped, rather than dropping support across all active releases at a given time. |
Yep! These jobs were marked as deprecated in #20964. As part of kubernetes/release#1711 (using krel for CI builds), #20663 set the krel ci-build as the de facto CI build. Let's hang tight for Aaron to provide feedback on what he wànts next steps to be. /assign @spiffxp EDIT:
|
@BobyMCbobs: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d217087
to
923638e
Compare
Rebased now, @alvaroaleman |
@hasheddan @justaugustus this is something we still want to move? what are the blockers to merge this PR? there is anything that I can help to unblock this? |
/close Closure would look like:
It might be worth a KEP to enumerate the full scope of changes required, if not some iteration over a proposal or umbrella issue ref: kubernetes/k8s.io#846 |
@spiffxp: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Promote use of k8s-staging-ci-images.
Related: kubernetes/k8s.io#1460