Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s Versions For Descheduler E2E Tests #22238

Merged
merged 1 commit into from
May 19, 2021
Merged

Bump k8s Versions For Descheduler E2E Tests #22238

merged 1 commit into from
May 19, 2021

Conversation

seanmalloy
Copy link
Member

  • Add k8s 1.21.1
  • Bump to k8s 1.20.7
  • Bump to k8s 1.19.11
  • Remove k8s 1.18

The above versions align with the kind v0.11.0 release.

@seanmalloy
Bump k8s Versions For Descheduler E2E Tests
568d2dc 
* Add k8s 1.21.1
* Bump to k8s 1.20.7
* Bump to k8s 1.19.11
* Remove k8s 1.18

The above versions align with the kind v0.11.0 release.
@k8s-ci-robot
Copy link
Contributor

Hi @seanmalloy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 19, 2021
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims May 19, 2021 05:34
@seanmalloy
Copy link
Member Author

PR kubernetes-sigs/descheduler#570 must be merged first.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021
@seanmalloy seanmalloy mentioned this pull request May 19, 2021
Closed
@seanmalloy
Copy link
Member Author

This one can merge after kubernetes-sigs/descheduler#570 is merged.

/assign @damemi @ingvagabund

damemi
damemi reviewed May 19, 2021
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@ingvagabund
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit b8b46cb into kubernetes:master May 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 19, 2021
@k8s-ci-robot
Copy link
Contributor

@seanmalloy: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key descheduler-presubmits-master.yaml using file config/jobs/kubernetes-sigs/descheduler/descheduler-presubmits-master.yaml

In response to this:

  • Add k8s 1.21.1
  • Bump to k8s 1.20.7
  • Bump to k8s 1.19.11
  • Remove k8s 1.18

The above versions align with the kind v0.11.0 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seanmalloy seanmalloy deleted the bump-descheduler-k8s-e2e-version branch May 19, 2021 14:57
@seanmalloy seanmalloy mentioned this pull request Aug 19, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@chases2 chases2 Awaiting requested review from chases2

@dims dims Awaiting requested review from dims

Assignees

@damemi damemi

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@seanmalloy @k8s-ci-robot @ingvagabund @damemi