Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: add sharding support for bugzilla #22427

Merged
merged 3 commits into from
Jun 9, 2021
Merged

plugins: add sharding support for bugzilla #22427

merged 3 commits into from
Jun 9, 2021

Conversation

AlexNPavel
Copy link
Contributor

This PR adds config sharding support for the bugzilla plugin.

/cc @stevekuznetsov @alvaroaleman

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow area/prow/plugins Issues or PRs related to prow's plugins for the hook component sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2021
@AlexNPavel AlexNPavel changed the title plugins: add sharding support fot bugzilla plugins: add sharding support for bugzilla Jun 4, 2021
@AlexNPavel
plugins: add sharding support for bugzilla
94f76c4 
This PR adds config sharding support for the bugzilla plugin.
@AlexNPavel AlexNPavel force-pushed the shard-bugzilla-config branch from 0dc0b44 to 94f76c4 Compare June 4, 2021 23:15
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
alvaroaleman
alvaroaleman reviewed Jun 7, 2021
View reviewed changes
prow/plugins/config.go Show resolved Hide resolved
prow/plugins/config.go Outdated Show resolved Hide resolved
prow/plugins/config.go Outdated Show resolved Hide resolved
alvaroaleman
alvaroaleman reviewed Jun 7, 2021
View reviewed changes
prow/plugins/config.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@AlexNPavel
Copy link
Contributor Author

Updated PR to remove weird pointer stuff I was doing and update the HasConfigFor function

@AlexNPavel
Copy link
Contributor Author

/retest

alvaroaleman
alvaroaleman reviewed Jun 9, 2021
View reviewed changes
prow/plugins/config.go Outdated Show resolved Hide resolved
prow/plugins/config_test.go Outdated Show resolved Hide resolved
alvaroaleman
alvaroaleman approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, alvaroaleman, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 402d3ba into kubernetes:master Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 9, 2021
@AlexNPavel AlexNPavel deleted the shard-bugzilla-config branch June 9, 2021 21:39
@palnabarun palnabarun mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@petr-muller petr-muller petr-muller approved these changes

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@petr-muller petr-muller

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexNPavel @k8s-ci-robot @petr-muller @alvaroaleman