Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows k8s upstream CI presubmit for capz #22485

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Add windows k8s upstream CI presubmit for capz #22485

merged 2 commits into from
Jun 8, 2021

Conversation

jsturtevant
Copy link
Contributor

This will allow validation of kubernetes-sigs/cluster-api-provider-azure#1388

/assign @chewong @CecileRobertMichon
/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from cpanato and juan-lee June 8, 2021 21:30
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021
chewong
chewong approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
CecileRobertMichon
CecileRobertMichon reviewed Jun 8, 2021
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@jsturtevant jsturtevant mentioned this pull request Jun 8, 2021
Merged
3 tasks
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@jsturtevant
Copy link
Contributor Author

I needed to add to get the latest images.

      - name: WIN_REPO_LIST
      - value https://raw.githubusercontent.com/kubernetes-sigs/windows-testing/master/images/image-repo-list-master

chewong
chewong approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, chewong, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 94f3f23 into kubernetes:master Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits.yaml

In response to this:

This will allow validation of kubernetes-sigs/cluster-api-provider-azure#1388

/assign @chewong @CecileRobertMichon
/sig windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@chewong chewong chewong approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@juan-lee juan-lee Awaiting requested review from juan-lee

Assignees

@CecileRobertMichon CecileRobertMichon

@chewong chewong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@jsturtevant @k8s-ci-robot @CecileRobertMichon @chewong