skip_report flag in prowjob only used by crier reporters that report back to CI system

[chaodaiG]

skip_report initially was meant for skipping reporting on github as comment at

test-infra/prow/config/jobs.go

Line 231 in 3be10e8

// SkipReport skips commenting and setting status on GitHub.

. This has later on been used for skipping all crier reporters as

test-infra/prow/crier/controller.go

Line 181 in 6c4a2b3

if !pj.Spec.Report || !r.reporter.ShouldReport(ctx, log, &pj) {

and

test-infra/prow/pjutil/pjutil.go

Line 126 in 6c4a2b3

pjs.Report = !p.SkipReport

.

gcsreporter is responsible for uploading finished.json when sidecar failed to do so, as well as uploading prowjob.json. These should happen independent of skip_report.

This PR classifies crier reporters to be either report back to or not to CI system, and skip_report is only respected by reporters that report back to CI system.

[chaodaiG]

/cc @cjwagner @alvaroaleman @fejta @michelle192837

[fejta]

This PR is unnecessary

[chaodaiG]

This PR is unnecessary

Had synced offline with @fejta, and updated PR description with more context, also this PR is open to discussion

[chaodaiG]

The other reporter could benefit from this is pubsub reporter

[fejta]

/hold

If we're concerned about safety we could add a reporter.AlwaysTryReport() or something, but maybe not worth it

[chaodaiG]

the previous commit marked gcs/kubernetes reporter instead of gerrit reporter as CI reporter, fixed by force push

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• prow/crier/OWNERS [chaodaiG,fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chaodaiG]

@alvaroaleman , any objection before I unhold this PR?

[alvaroaleman]

no, sounds good to me. It makes the meaning of this field a bit confusing (maybe godoc that reporters themselves decide if they respect it?) but having something like k8s reporter always report makes a lot of sense.
/hold cancel