Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate tags for [Node(Alpha|Special)Feature:Foo] deprecation #22677

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Duplicate tags for [Node(Alpha|Special)Feature:Foo] deprecation #22677

merged 4 commits into from
Jul 15, 2021

Conversation

mmiranda96
Copy link
Contributor

As an effort to remove undocumented [Node(Alpha|Special)?Feature:Foo] tags (see kubernetes/kubernetes#94289), this PR focuses on the first step: adding tags [Node(Alpha|Special)?Feature].

Currently no tests in kubernetes/kubernetes have tags with the new format, so this PR should not change any behavior.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @mmiranda96!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mmiranda96. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and hasheddan June 23, 2021 20:53
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/k8s-infra labels Jun 23, 2021
@SergeyKanzhelev
Copy link
Member

/ok-to-test
/lgtm
/priority backlog

good first step

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2021
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jun 30, 2021
Closed
ehashman
ehashman reviewed Jun 30, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SergeyKanzhelev
Copy link
Member

/assign @spiffxp

@spiffxp can you please approve this PR since you started the issue kubernetes/kubernetes#94289 - it doesn't have much logic, but touches too many components to chase individual people.

@mmiranda96 mmiranda96 mentioned this pull request Jul 13, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2021
@mmiranda96 mmiranda96 force-pushed the fix/dedupe-node-feature-tags branch from 66bc6ce to 52653e8 Compare July 15, 2021 17:40
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 15, 2021
@mmiranda96
Copy link
Contributor Author

Requesting LGTM again.

spiffxp
spiffxp approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmiranda96, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 769f659 into kubernetes:master Jul 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

@mmiranda96: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd-presubmit-jobs.yaml using file config/jobs/containerd/containerd/containerd-presubmit-jobs.yaml
  • key containerd-cri-presubmit-jobs.yaml using file config/jobs/containerd/cri/containerd-cri-presubmit-jobs.yaml
  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml
  • key crio.yaml using file config/jobs/kubernetes/sig-node/crio.yaml
  • key node-docker.yaml using file config/jobs/kubernetes/sig-node/node-docker.yaml
  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml
  • key 1.20.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.20.yaml
  • key 1.21.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.21.yaml
  • key sig-node-containerd.yaml using file config/jobs/kubernetes/wg-k8s-infra/canaries/sig-node-containerd.yaml

In response to this:

As an effort to remove undocumented [Node(Alpha|Special)?Feature:Foo] tags (see kubernetes/kubernetes#94289), this PR focuses on the first step: adding tags [Node(Alpha|Special)?Feature].

Currently no tests in kubernetes/kubernetes have tags with the new format, so this PR should not change any behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmiranda96 mmiranda96 deleted the fix/dedupe-node-feature-tags branch July 15, 2021 18:12
@mmiranda96 mmiranda96 mentioned this pull request Sep 9, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees

@spiffxp spiffxp

@ehashman ehashman

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Archived in project
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@mmiranda96 @k8s-ci-robot @SergeyKanzhelev @spiffxp @ehashman