Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scanning to triage privately #22833

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Update scanning to triage privately #22833

merged 1 commit into from
Jul 12, 2021

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Jul 8, 2021

  • Refactors storing of results from file artifacts
    to bash variables
  • Alert on failure, where failure is defined as
    synk command failed or the filtering of vulnerabilities
    was unsuccessful
  • Adds group email address for triage notifications

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from fejta and thockin July 8, 2021 23:44
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2021
@PushkarJ PushkarJ force-pushed the snyk-triage-priv branch from 436d600 to 2e72baf Compare July 9, 2021 00:10
@PushkarJ PushkarJ marked this pull request as ready for review July 9, 2021 03:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2021
@PushkarJ PushkarJ force-pushed the snyk-triage-priv branch 2 times, most recently from 89749d2 to 6f3bdde Compare July 9, 2021 03:50
@PushkarJ
Copy link
Member Author

PushkarJ commented Jul 9, 2021

/assign @navidshaikh

/sig security testing
/area jobs config testgrid

@k8s-ci-robot k8s-ci-robot added sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. area/jobs area/config Issues or PRs related to code in /config area/testgrid labels Jul 9, 2021
@PushkarJ PushkarJ mentioned this pull request Jul 9, 2021
Closed
navidshaikh
navidshaikh suggested changes Jul 9, 2021
View reviewed changes
Copy link
Member

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @spiffxp

@k8s-ci-robot k8s-ci-robot requested a review from spiffxp July 9, 2021 17:43
@PushkarJ
Update scanning to triage privately
12bf7f0 
- Refactors storing of results from file artifacts
to bash variables
- Alert on failure, where failure is defined as
synk command failed or the filtering of vulnerabilities
was unsuccessful
- Adds group email address for triage notifications
- Improved error handling

- Make the log messages consistent in casing
@PushkarJ PushkarJ force-pushed the snyk-triage-priv branch from 40b379d to 12bf7f0 Compare July 9, 2021 18:48
@navidshaikh
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
@PushkarJ
Copy link
Member Author

PushkarJ commented Jul 9, 2021

/assign @michelle192837

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, PushkarJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7c109d9 into kubernetes:master Jul 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 12, 2021
@k8s-ci-robot
Copy link
Contributor

@PushkarJ: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key wg-k8s-infra-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-trusted.yaml

In response to this:

  • Refactors storing of results from file artifacts
    to bash variables
  • Alert on failure, where failure is defined as
    synk command failed or the filtering of vulnerabilities
    was unsuccessful
  • Adds group email address for triage notifications

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PushkarJ PushkarJ mentioned this pull request Jul 15, 2021
Merged
@PushkarJ PushkarJ mentioned this pull request Aug 3, 2021
Closed
@PushkarJ PushkarJ mentioned this pull request Sep 14, 2021
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidshaikh navidshaikh navidshaikh requested changes

@michelle192837 michelle192837 michelle192837 approved these changes

@fejta fejta Awaiting requested review from fejta

@thockin thockin Awaiting requested review from thockin

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@michelle192837 michelle192837

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@PushkarJ @k8s-ci-robot @navidshaikh @michelle192837