Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prow transfer issue #23153

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Add prow transfer issue #23153

merged 1 commit into from
Aug 26, 2021

Conversation

eddiezane
Copy link
Member

Fixes: #18117

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2021
@eddiezane eddiezane mentioned this pull request Aug 6, 2021
Closed
@eddiezane eddiezane changed the title Add prow migrate issue Add prow transfer issue Aug 6, 2021
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from 243b7ab to 7216283 Compare August 6, 2021 18:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/prow/hook Issues or PRs related to prow's hook component area/prow/plugins Issues or PRs related to prow's plugins for the hook component and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2021
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from 62eb69f to f9617b3 Compare August 12, 2021 01:42
@eddiezane
Copy link
Member Author

@spiffxp @BenTheElder this is ready for an early look while I write some tests and figure out how to run it 😅. Can confirm the GraphQL request works though.

Couple open questions that might be for someone familiar with Prow plugin UX.

@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from f9617b3 to e28589b Compare August 12, 2021 01:47
petr-muller
petr-muller reviewed Aug 12, 2021
View reviewed changes
prow/plugins/transfer-issue/transfer-issue.go Outdated Show resolved Hide resolved
prow/plugins/transfer-issue/transfer-issue.go Outdated Show resolved Hide resolved
prow/plugins/transfer-issue/transfer-issue.go Outdated Show resolved Hide resolved
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from e28589b to f7319af Compare August 16, 2021 23:14
@fejta fejta added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 17, 2021
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from f7319af to aa2f62d Compare August 17, 2021 21:49
@eddiezane eddiezane marked this pull request as ready for review August 17, 2021 21:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2021
@eddiezane
Copy link
Member Author

eddiezane commented Aug 17, 2021 •
edited
Loading

This is ready for review. I've yet to test the plugin on an actual prow deployment but will start standing that up now (unless someone wants to give it a spin on theirs).

Commits are my journey but I can squash before merge.

/cc @alvaroaleman

TODO:

  • Bazel
  • Wire up plugin correctly

alvaroaleman
alvaroaleman reviewed Aug 17, 2021
View reviewed changes
prow/github/client.go Show resolved Hide resolved
prow/github/client.go Outdated Show resolved Hide resolved
prow/plugins/transfer-issue/transfer-issue.go Outdated Show resolved Hide resolved
prow/plugins/transfer-issue/transfer-issue.go Outdated Show resolved Hide resolved
prow/plugins/transfer-issue/transfer-issue.go Outdated Show resolved Hide resolved
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch 3 times, most recently from bf082a2 to c291618 Compare August 19, 2021 19:49
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from c291618 to 37c11c4 Compare August 19, 2021 20:34
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from 37c11c4 to 042ed02 Compare August 23, 2021 18:21
petr-muller
petr-muller approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2021
@eddiezane
Copy link
Member Author

I'll get this tested irl later today.

@eddiezane
Copy link
Member Author

It works!

kuberneddies/test-repo-2#2

2021-08-24_10-30

/assign @alvaroaleman

alvaroaleman
alvaroaleman reviewed Aug 26, 2021
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small remarks, other than that it looks good. Thanks for your work!

prow/plugins/transfer-issue/transfer-issue_test.go Outdated Show resolved Hide resolved
prow/plugins/transfer-issue/transfer-issue.go Outdated Show resolved Hide resolved
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from 042ed02 to 84295da Compare August 26, 2021 22:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
@eddiezane
Copy link
Member Author

@alvaroaleman thanks! Changes made.

@eddiezane
Add prow transfer-issue plugin
ce9ffe9 
Signed-off-by: Eddie Zaneski <eddiezane@gmail.com>
@eddiezane eddiezane force-pushed the ez/prow-transfer-issue branch from 84295da to ce9ffe9 Compare August 26, 2021 23:15
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, eddiezane, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit b031910 into kubernetes:master Aug 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 26, 2021
@eddiezane eddiezane deleted the ez/prow-transfer-issue branch August 27, 2021 00:15
@eddiezane eddiezane mentioned this pull request Sep 2, 2021
Merged
@sftim sftim mentioned this pull request Oct 2, 2021
Closed
@palnabarun palnabarun mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@petr-muller petr-muller petr-muller approved these changes

@fejta fejta Awaiting requested review from fejta

Assignees

@petr-muller petr-muller

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/hook Issues or PRs related to prow's hook component area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Command to move issue to a new repository
5 participants
@eddiezane @k8s-ci-robot @petr-muller @alvaroaleman @fejta