-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create containerd 1.5 canaries #23215
Create containerd 1.5 canaries #23215
Conversation
Hi @mmiranda96. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc ehashman |
/ok-to-test |
config/jobs/kubernetes/wg-k8s-infra/canaries/sig-node-containerd.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes/wg-k8s-infra/canaries/sig-node-containerd.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes/wg-k8s-infra/canaries/sig-node-containerd.yaml
Outdated
Show resolved
Hide resolved
jobs/e2e_node/containerd/containerd-release-1.5/image-config.yaml
Outdated
Show resolved
Hide resolved
e31dab9
to
11d16bc
Compare
config/jobs/kubernetes/wg-k8s-infra/canaries/sig-node-containerd.yaml
Outdated
Show resolved
Hide resolved
jobs/e2e_node/containerd/containerd-release-1.5/image-config.yaml
Outdated
Show resolved
Hide resolved
jobs/e2e_node/containerd/containerd-release-1.5/image-config.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes/wg-k8s-infra/canaries/sig-node-containerd.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes/wg-k8s-infra/canaries/sig-node-containerd.yaml
Outdated
Show resolved
Hide resolved
11d16bc
to
06788e3
Compare
Gentle ping for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the kubekins images have been updated
from --> gcr.io/k8s-testimages/kubekins-e2e:v20210825-bb6d84a-master
to --> gcr.io/k8s-testimages/kubekins-e2e:v20210825-f1955d1-master
config/jobs/kubernetes/wg-k8s-infra/canaries/sig-node-containerd.yaml
Outdated
Show resolved
Hide resolved
jobs/e2e_node/containerd/containerd-release-1.5/image-config.yaml
Outdated
Show resolved
Hide resolved
/assign @spiffxp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tl;dr I think these would better belong in kubernetes/sig-node/containerd.yaml
, without the -canary
suffixes
Apologies for the lack of documentation here, but generally jobs in sig-k8s-infra/canaries are duplicates of jobs elsewhere that run in the default
cluster, solely to make sure they run OK in k8s-infra-prow-build
. We probably have more jobs there than we need to at this point; they're intended to be temporary, long enough to verify whether a job that currently runs in default
runs the same way in k8s-infra-prow-build
In this case, these jobs don't already exist in default
, and they seem more directly under the purview of SIG Node.
Moving now to the proper directory. Does it make sense to use the same base configuration as the jobs in the new directory? (changing base image, labels, arguments, and resources) |
The only thing that comes to mind is the testgrids should also be something with the word sig-node in them, porbably sig-node-containerd. As I'm looking at https://testgrid.k8s.io/sig-node-containerd I'm noticing the 1.4 e2e jobs appear to be failing, seems like the clusters aren't coming up? Might be good to figure out why those are failing (or drop them if no longer relevant) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, mmiranda96, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks to @adisky, 1.4 canaries are now passing. I feel more confident pushing this now. |
/unhold |
@mmiranda96: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Create new canary jobs for containerd 1.5
Following the structure of canaries for v1.4, these are the new ProwJobs:
ci-containerd-build-1-5-canary
ci-containerd-node-e2e-1-5-canary
ci-containerd-node-e2e-features-1-5-canary
Closes #23131