Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create containerd 1.5 canaries #23215

Merged

Conversation

mmiranda96
Copy link
Contributor

Create new canary jobs for containerd 1.5

Following the structure of canaries for v1.4, these are the new ProwJobs:

  • ci-containerd-build-1-5-canary
  • ci-containerd-node-e2e-1-5-canary
  • ci-containerd-node-e2e-features-1-5-canary

Closes #23131

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @mmiranda96. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Aug 11, 2021
@mmiranda96
Copy link
Contributor Author

/cc ehashman
/cc endocrimes
/cc dims

@ehashman
Copy link
Member

/ok-to-test
/assign @endocrimes

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2021
@mmiranda96 mmiranda96 force-pushed the fix/containerd-1.5-canaries branch from e31dab9 to 11d16bc Compare August 11, 2021 22:10
@mmiranda96 mmiranda96 force-pushed the fix/containerd-1.5-canaries branch from 11d16bc to 06788e3 Compare August 16, 2021 14:38
@mmiranda96
Copy link
Contributor Author

Gentle ping for another review.

Copy link
Contributor

@adisky adisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the kubekins images have been updated
from --> gcr.io/k8s-testimages/kubekins-e2e:v20210825-bb6d84a-master
to --> gcr.io/k8s-testimages/kubekins-e2e:v20210825-f1955d1-master

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2021
@mmiranda96
Copy link
Contributor Author

/assign @spiffxp
PTAL

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr I think these would better belong in kubernetes/sig-node/containerd.yaml, without the -canary suffixes

Apologies for the lack of documentation here, but generally jobs in sig-k8s-infra/canaries are duplicates of jobs elsewhere that run in the default cluster, solely to make sure they run OK in k8s-infra-prow-build. We probably have more jobs there than we need to at this point; they're intended to be temporary, long enough to verify whether a job that currently runs in default runs the same way in k8s-infra-prow-build

In this case, these jobs don't already exist in default, and they seem more directly under the purview of SIG Node.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2021
@mmiranda96
Copy link
Contributor Author

Moving now to the proper directory. Does it make sense to use the same base configuration as the jobs in the new directory? (changing base image, labels, arguments, and resources)

@spiffxp
Copy link
Member

spiffxp commented Sep 28, 2021

The only thing that comes to mind is the testgrids should also be something with the word sig-node in them, porbably sig-node-containerd.

As I'm looking at https://testgrid.k8s.io/sig-node-containerd I'm noticing the 1.4 e2e jobs appear to be failing, seems like the clusters aren't coming up? Might be good to figure out why those are failing (or drop them if no longer relevant)

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2021
@mmiranda96
Copy link
Contributor Author

Apologies for the delay @spiffxp. I've moved the jobs to the proper directory. Additionally, I've filed #23915 to fix 1.4 canaries. I'll investigate on this before creating the new ones, I'm suspecting they will fail as well.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, mmiranda96, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmiranda96
Copy link
Contributor Author

Thanks to @adisky, 1.4 canaries are now passing. I feel more confident pushing this now.
/unblock

@mmiranda96
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 26af721 into kubernetes:master Oct 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 21, 2021
@k8s-ci-robot
Copy link
Contributor

@mmiranda96: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml

In response to this:

Create new canary jobs for containerd 1.5

Following the structure of canaries for v1.4, these are the new ProwJobs:

  • ci-containerd-build-1-5-canary
  • ci-containerd-node-e2e-1-5-canary
  • ci-containerd-node-e2e-features-1-5-canary

Closes #23131

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create canary jobs for containerd 1.5
8 participants