Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Tidy kpromo job configs #23430

Merged
merged 1 commit into from
Sep 1, 2021
Merged

releng: Tidy kpromo job configs #23430

merged 1 commit into from
Sep 1, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Aug 31, 2021 •
edited
Loading

  • the remaining promotion tools, including kpromo, have been moved
    back into the CIP repo
  • their GCB config has been merged with the existing CIP
    cloudbuild.yaml, so the individual jobs targeting k/release are no
    longer required
  • command invocation for periodic job is fixed to include the
    subcommand (kpromo run files ...)

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @ameukam @puerco @saschagrunert @cpanato
cc: @kubernetes/release-engineering
ref: kubernetes-sigs/promo-tools#408, kubernetes/k8s.io#2624

@justaugustus
releng: Tidy kpromo job configs
3106219 
- the remaining promotion tools, including `kpromo`, have been moved
  back into the CIP repo
- their GCB config has been merged with the existing CIP
  cloudbuild.yaml, so the individual jobs targeting k/release are no
  longer required
- command invocation for periodic job is fixed to include the
  subcommand (`kpromo run files ...`)

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 31, 2021
@justaugustus justaugustus mentioned this pull request Aug 31, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2021
cpanato
cpanato approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c37efa0 into kubernetes:master Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 1, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-artifact-promoter.yaml using file config/jobs/image-pushing/releng/k8s-staging-artifact-promoter.yaml
  • key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml
  • key releng-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/releng/releng-trusted.yaml

In response to this:

  • the remaining promotion tools, including kpromo, have been moved
    back into the CIP repo
  • their GCB config has been merged with the existing CIP
    cloudbuild.yaml, so the individual jobs targeting k/release are no
    longer required
  • command invocation for periodic job is fixed to include the
    subcommand (kpromo run files ...)

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @ameukam @puerco @saschagrunert @cpanato
cc: @kubernetes/release-engineering
ref: kubernetes-sigs/promo-tools#408, kubernetes/k8s.io#2624

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus mentioned this pull request Sep 8, 2021
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @saschagrunert @cpanato @ameukam @puerco