releng(kpromo): Drop --use-service-account flag

[justaugustus]

In a previous commit (from #23493), the --use-service-account
flag was added for kpromo jobs, but it might not actually be
necessary (as we're already running in containers with access to
service accounts).

Let's validate this before touching the legacy code paths in CIP
(which handle auth via service account) or building/promoting a
new image containing gcloud SDK binaries.

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @ameukam @puerco @saschagrunert @cpanato
cc: @kubernetes/release-engineering

---

Example failures:

From https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-k8sio-file-promo/1435127641098162176:

********** START **********
level=info msg="processing destination \"gs://k8s-artifacts-prod/binaries/kops/\""
level=info msg="listing files in bucket k8s-staging-kops with prefix \"kops/releases/\""
level=info msg="listing files in bucket k8s-artifacts-prod with prefix \"binaries/kops/\""
level=info msg="getting service-account-token for \"k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com\""
level=error msg="could not execute cmd gcloud auth --account=k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com print-access-token"
level=warning msg="failed to get service-account-token for \"k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com\": exec: \"gcloud\": executable file not found in $PATH"
level=fatal msg="run `kpromo run files`: error building operations: error building promotion operations for \"gs://k8s-artifacts-prod/binaries/kops/\": error listing objects in \"gs://k8s-artifacts-prod/binaries/kops/\": Get \"https://storage.googleapis.com/storage/v1/b/k8s-artifacts-prod/o?alt=json&delimiter=&endOffset=&pageToken=&prefix=binaries%2Fkops%2F&prettyPrint=false&projection=full&startOffset=&versions=false\": exec: \"gcloud\": executable file not found in $PATH"

From https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/2663/pull-k8sio-file-promo/1435121919522246656:

********** START (DRY RUN) **********
level=info msg="processing destination \"gs://k8s-staging-cri-tools/releases/\""
level=info msg="listing files in bucket k8s-artifacts-cri-tools with prefix \"release/\""
level=info msg="listing files in bucket k8s-staging-cri-tools with prefix \"releases/\""
level=info msg="getting service-account-token for \"k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com\""
level=error msg="could not execute cmd gcloud auth --account=k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com print-access-token"
level=warning msg="failed to get service-account-token for \"k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com\": exec: \"gcloud\": executable file not found in $PATH"
level=fatal msg="run `kpromo run files`: error building operations: error building promotion operations for \"gs://k8s-staging-cri-tools/releases/\": error listing objects in \"gs://k8s-staging-cri-tools/releases/\": Get \"https://storage.googleapis.com/storage/v1/b/k8s-staging-cri-tools/o?alt=json&delimiter=&endOffset=&pageToken=&prefix=releases%2F&prettyPrint=false&projection=full&startOffset=&versions=false\": exec: \"gcloud\": executable file not found in $PATH"

[ameukam]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-release/cip/OWNERS [justaugustus,saschagrunert]
• config/jobs/kubernetes/wg-k8s-infra/trusted/releng/OWNERS [justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key container-image-promoter.yaml using file config/jobs/kubernetes/sig-release/cip/container-image-promoter.yaml
• key releng-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/releng/releng-trusted.yaml

In response to this:

In a previous commit (from #23493), the --use-service-account
flag was added for kpromo jobs, but it might not actually be
necessary (as we're already running in containers with access to
service accounts).

Let's validate this before touching the legacy code paths in CIP
(which handle auth via service account) or building/promoting a
new image containing gcloud SDK binaries.

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @ameukam @puerco @saschagrunert @cpanato
cc: @kubernetes/release-engineering

---

Example failures:

From https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-k8sio-file-promo/1435127641098162176:

********** START **********
level=info msg="processing destination \"gs://k8s-artifacts-prod/binaries/kops/\""
level=info msg="listing files in bucket k8s-staging-kops with prefix \"kops/releases/\""
level=info msg="listing files in bucket k8s-artifacts-prod with prefix \"binaries/kops/\""
level=info msg="getting service-account-token for \"k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com\""
level=error msg="could not execute cmd gcloud auth --account=k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com print-access-token"
level=warning msg="failed to get service-account-token for \"k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com\": exec: \"gcloud\": executable file not found in $PATH"
level=fatal msg="run `kpromo run files`: error building operations: error building promotion operations for \"gs://k8s-artifacts-prod/binaries/kops/\": error listing objects in \"gs://k8s-artifacts-prod/binaries/kops/\": Get \"https://storage.googleapis.com/storage/v1/b/k8s-artifacts-prod/o?alt=json&delimiter=&endOffset=&pageToken=&prefix=binaries%2Fkops%2F&prettyPrint=false&projection=full&startOffset=&versions=false\": exec: \"gcloud\": executable file not found in $PATH"

From https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/2663/pull-k8sio-file-promo/1435121919522246656:

********** START (DRY RUN) **********
level=info msg="processing destination \"gs://k8s-staging-cri-tools/releases/\""
level=info msg="listing files in bucket k8s-artifacts-cri-tools with prefix \"release/\""
level=info msg="listing files in bucket k8s-staging-cri-tools with prefix \"releases/\""
level=info msg="getting service-account-token for \"k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com\""
level=error msg="could not execute cmd gcloud auth --account=k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com print-access-token"
level=warning msg="failed to get service-account-token for \"k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com\": exec: \"gcloud\": executable file not found in $PATH"
level=fatal msg="run `kpromo run files`: error building operations: error building promotion operations for \"gs://k8s-staging-cri-tools/releases/\": error listing objects in \"gs://k8s-staging-cri-tools/releases/\": Get \"https://storage.googleapis.com/storage/v1/b/k8s-staging-cri-tools/o?alt=json&delimiter=&endOffset=&pageToken=&prefix=releases%2F&prettyPrint=false&projection=full&startOffset=&versions=false\": exec: \"gcloud\": executable file not found in $PATH"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.