Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secret-store-csi-driver: prepend iptables fixes for #23741 #23743

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented Sep 24, 2021

Attempt fix for #23741 based on initial success of kubernetes-sigs/secrets-store-csi-driver#749

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2021
@tam7t tam7t changed the title fix: prepend iptables fixes for #23741 secret-store-csi-driver: prepend iptables fixes for #23741 Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2021
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit b7577e2 into kubernetes:master Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

@tam7t: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key secrets-store-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml
  • key secrets-store-csi-driver-release-0.1-config.yaml using file config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-release-0.1-config.yaml

In response to this:

Attempt fix for #23741 based on initial success of kubernetes-sigs/secrets-store-csi-driver#749

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants