Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-alpha features from jobs. #23845

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

rayandas
Copy link
Member

This PR remove non-alpha features from job ci-kubernetes-e2e-gci-gce-alpha-features and pull-kubernetes-e2e-gce-alpha-features.
Partially fixes #23642

Signed-off-by: Rayan Das rayandas91@gmail.com

…atures and pull-kubernetes-e2e-gce-alpha-features

Signed-off-by: Rayan Das <rayandas91@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @rayandas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 30, 2021
@rayandas
Copy link
Member Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@rayandas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayandas
Copy link
Member Author

cc: @mmiranda96

@spiffxp
Copy link
Member

spiffxp commented Sep 30, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2021
@mmiranda96
Copy link
Contributor

Thanks for your work @rayandas ! Let's run these jobs and see the result.
/test pull-kubernetes-e2e-gce-alpha-features
/test ci-kubernetes-e2e-gci-gce-alpha-features

@k8s-ci-robot
Copy link
Contributor

@mmiranda96: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-test-infra-bazel
  • /test pull-test-infra-gubernator
  • /test pull-test-infra-verify-file-perms
  • /test pull-test-infra-yamllint
  • /test pull-test-infra-prow-checkconfig
  • /test pull-test-infra-integration
  • /test pull-test-infra-test-beta

Use /test all to run the following jobs that were automatically triggered:

  • pull-test-infra-bazel
  • pull-test-infra-gubernator
  • pull-test-infra-verify-file-perms
  • pull-test-infra-yamllint
  • pull-test-infra-prow-checkconfig
  • pull-test-infra-integration

In response to this:

Thanks for your work @rayandas ! Let's run these jobs and see the result.
/test pull-kubernetes-e2e-gce-alpha-features
/test ci-kubernetes-e2e-gci-gce-alpha-features

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmiranda96
Copy link
Contributor

I think I can't trigger the CI job. Triggering just the PR job...
/test pull-kubernetes-e2e-gce-alpha-features

@k8s-ci-robot
Copy link
Contributor

@mmiranda96: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-test-infra-bazel
  • /test pull-test-infra-gubernator
  • /test pull-test-infra-verify-file-perms
  • /test pull-test-infra-yamllint
  • /test pull-test-infra-prow-checkconfig
  • /test pull-test-infra-integration
  • /test pull-test-infra-test-beta

Use /test all to run the following jobs that were automatically triggered:

  • pull-test-infra-bazel
  • pull-test-infra-gubernator
  • pull-test-infra-verify-file-perms
  • pull-test-infra-yamllint
  • pull-test-infra-prow-checkconfig
  • pull-test-infra-integration

In response to this:

I think I can't trigger the CI job. Triggering just the PR job...
/test pull-kubernetes-e2e-gce-alpha-features

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayandas
Copy link
Member Author

rayandas commented Oct 1, 2021

@mmiranda96 I think we cant trigger pull-kubernetes-e2e-gce-alpha-features job also. It has to be one from the bot's message above.

@mmiranda96
Copy link
Contributor

Yeah, I'm not sure why the job doesn't trigger. I'll ask about it on Slack.

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
FWIW I'm inclined to suggest we just merge this and watch the CI job to see if it breaks. If it does, we can revert and take the more cautious route of duplicating the presubmit as a manually triggered job under a new name like pull-kubernetes-e2e-gce-alpha-features-canary

/hold
Please /hold cancel if you agree with this approach, or update the PR to take the more cautious approach first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayandas, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@mmiranda96
Copy link
Contributor

Considering that this PR only makes the test set smaller, I see very low risk.
/lgtm
/hold cancel

Thanks everyone!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit d88e8ef into kubernetes:master Oct 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

@rayandas: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

This PR remove non-alpha features from job ci-kubernetes-e2e-gci-gce-alpha-features and pull-kubernetes-e2e-gce-alpha-features.
Partially fixes #23642

Signed-off-by: Rayan Das rayandas91@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove non-alpha features from job ci-kubernetes-e2e-gci-gce-alpha-features
4 participants