-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-alpha features from jobs. #23845
Remove non-alpha features from jobs. #23845
Conversation
…atures and pull-kubernetes-e2e-gce-alpha-features Signed-off-by: Rayan Das <rayandas91@gmail.com>
Hi @rayandas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@rayandas: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc: @mmiranda96 |
/ok-to-test |
Thanks for your work @rayandas ! Let's run these jobs and see the result. |
@mmiranda96: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think I can't trigger the CI job. Triggering just the PR job... |
@mmiranda96: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mmiranda96 I think we cant trigger pull-kubernetes-e2e-gce-alpha-features job also. It has to be one from the bot's message above. |
Yeah, I'm not sure why the job doesn't trigger. I'll ask about it on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
FWIW I'm inclined to suggest we just merge this and watch the CI job to see if it breaks. If it does, we can revert and take the more cautious route of duplicating the presubmit as a manually triggered job under a new name like pull-kubernetes-e2e-gce-alpha-features-canary
/hold
Please /hold cancel
if you agree with this approach, or update the PR to take the more cautious approach first
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rayandas, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Considering that this PR only makes the test set smaller, I see very low risk. Thanks everyone! |
@rayandas: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR remove non-alpha features from job ci-kubernetes-e2e-gci-gce-alpha-features and pull-kubernetes-e2e-gce-alpha-features.
Partially fixes #23642
Signed-off-by: Rayan Das rayandas91@gmail.com