Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sig-testing janitor jobs #23848

Merged
merged 2 commits into from
Oct 1, 2021
Merged

fix sig-testing janitor jobs #23848

merged 2 commits into from
Oct 1, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 30, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/scenarios sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2021
@spiffxp spiffxp mentioned this pull request Sep 30, 2021
Open
17 tasks
@spiffxp
Copy link
Member Author

spiffxp commented Sep 30, 2021

/cc @cjwagner @BenTheElder

cjwagner
cjwagner approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I'm not previously familiar with these projects or the CI janitor jobs so it might be good to get another review if you think one is needed.
/hold

experiment/ci-janitor/main.go
Comment on lines +51 to +53
// k8s-infra projects, can't be cleaned by k8s-prow serviceaccounts
"k8s-infra-e2e-scale-5k-project",
"k8s-infra-e2e-gpu-project",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to list these in the other file you edited as well?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Oct 1, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit c920b4c into kubernetes:master Oct 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 1, 2021
@spiffxp spiffxp deleted the clean-janitor-projects branch November 1, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner approved these changes

@mpherman2 mpherman2 Awaiting requested review from mpherman2

@MushuEE MushuEE Awaiting requested review from MushuEE

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/scenarios cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @cjwagner