Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e for openstack cloud provider keystone test #24217

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Add e2e for openstack cloud provider keystone test #24217

merged 1 commit into from
Nov 4, 2021

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Nov 3, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2021
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Nov 3, 2021
@jichenjc
Copy link
Contributor Author

jichenjc commented Nov 3, 2021

@lingxiankong can you help take a quick look? Thanks

@k8s-ci-robot k8s-ci-robot added area/jobs area/provider/openstack Issues or PRs related to openstack provider area/testgrid sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 3, 2021
@lingxiankong
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1e74d97 into kubernetes:master Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

@jichenjc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key provider-openstack-presubmits-release-master-config.yaml using file config/jobs/kubernetes/cloud-provider-openstack/provider-openstack-presubmits-release-master-config.yaml

In response to this:

related to kubernetes/cloud-provider-openstack#1680

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrigl chrigl Awaiting requested review from chrigl

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees

@lingxiankong lingxiankong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/openstack Issues or PRs related to openstack provider area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@jichenjc @lingxiankong @k8s-ci-robot