-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove branch protection on gh-pages
for external-dns & metrics-server Helm chart publish
#24222
Remove branch protection on gh-pages
for external-dns & metrics-server Helm chart publish
#24222
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Welcome @stevehipwell! |
Hi @stevehipwell. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
FYI @serathius @Raffo this should fix the issues with the last few chart releases. CC @gjtempleton |
/assign @chases2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, spiffxp, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stevehipwell: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Helm chart releases for external-dns & metrics-server have been failing due to the
gh-pages
branch being protected, this PR aims to follow cluster-autoscaler (amongst others) in fixing this.