Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: mv bazelbuild, benchmarkjunit pushes off test-infra-trusted #24229

Merged
merged 1 commit into from
Nov 5, 2021
Merged

config/jobs: mv bazelbuild, benchmarkjunit pushes off test-infra-trusted #24229

merged 1 commit into from
Nov 5, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Nov 3, 2021

Related:

Remove the jobs that ran on test-infra-trusted, and drop -canary from the jobs that push to gcr.io/k8s-staging-test-infra

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2021
@spiffxp spiffxp mentioned this pull request Nov 3, 2021
Open
77 tasks
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Nov 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 3, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Nov 4, 2021

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam November 4, 2021 22:53
@ameukam
Copy link
Member

ameukam commented Nov 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6dbe1bb into kubernetes:master Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-test-infra.yaml using file config/jobs/image-pushing/k8s-staging-test-infra.yaml
  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Related:

Remove the jobs that ran on test-infra-trusted, and drop -canary from the jobs that push to gcr.io/k8s-staging-test-infra

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the rm-old-image-push-jobs branch November 18, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @ameukam