Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-node: skip DynamicKubeletConfig test under serial lanes #24234

Merged
merged 1 commit into from
Nov 4, 2021
Merged

sig-node: skip DynamicKubeletConfig test under serial lanes #24234

merged 1 commit into from
Nov 4, 2021

Conversation

cynepco3hahue
Copy link

The DynamicKubeletConfig already deprecated and should be removed under
release 1.23, so it no taste to run it under serial lanes anymore.

Signed-off-by: Artyom Lukianov alukiano@redhat.com

sig-node: skip DynamicKubeletConfig test under serial lanes
8e6867a 
The DynamicKubeletConfig already deprecated and should be removed under
release 1.23, so it no taste to run it under serial lanes anymore.

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 4, 2021
@cynepco3hahue cynepco3hahue mentioned this pull request Nov 4, 2021
Merged
SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was discussed on SIG Node CI meeting. We are decreasing code coverage, but the feature is deprecated and causing a lot of troubles for tests stability. So it is ok to skip.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cynepco3hahue, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit a8fd853 into kubernetes:master Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 4, 2021
@k8s-ci-robot
Copy link
Contributor

@cynepco3hahue: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

The DynamicKubeletConfig already deprecated and should be removed under
release 1.23, so it no taste to run it under serial lanes anymore.

Signed-off-by: Artyom Lukianov alukiano@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Nov 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@karan karan Awaiting requested review from karan

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@cynepco3hahue @k8s-ci-robot @SergeyKanzhelev