Update/verify codegen by make rulew #24252
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
| echo "Install codegen tools." | ||
| cd "hack/tools" | ||
| clientgen=${REPO_ROOT}/_bin/client-gen | ||
| go build -o "${REPO_ROOT}/_bin/client-gen" k8s.io/code-generator/cmd/client-gen |
There was a problem hiding this comment.
I think it would make more sense to define make targets for these and make them dependencies of the update-codegen target. That would also let us avoid rebuilding them when not needed.
There was a problem hiding this comment.
Not quite sure that I'm getting the idea. If you mean create a new make target just for installing tools used by update-codegen, it would work but I'm not sure it's the best idea since this new target is used only by update-codegen, maybe not worth the effort of inflating root level Makefile?
For local development, this is pretty fast after the first time, mostly due to go cache I think
chaodaiG
force-pushed
the
codegen-makerule
branch
from
b1973f3 to
c546063
Compare
| echo "Install codegen tools." | ||
| cd "hack/tools" | ||
| clientgen=${REPO_ROOT}/_bin/client-gen | ||
| go build -o "${REPO_ROOT}/_bin/client-gen" k8s.io/code-generator/cmd/client-gen |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, cjwagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To make code reviewers' lives easier, this PR contains two commits: