Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd-node-features: skip dynamickubeletconfig tests #24279

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

endocrimes
Copy link
Member

DynamicKubeletConfig is not enabled by default (deprecated) and soon to be removed. Its tests are also incredibly flaky.

As the various changes to the test suite and runner happened, it seems that containerd's presubmits were missed, Rather than enabling the feature gate here, lets skip the tests as they're about to be removed and are low signal/high noise in presubmits.

xref: containerd/containerd#6215
follow up to: #24275

/cc @dims @adisky

DynamicKubeletConfig is not enabled by default (deprecated) and soon to be
removed. Its tests are also incredibly flaky.

As the various changes to the test suite and runner happened, it seems that
containerd's presubmits were missed, Rather than enabling the feature gate
here, lets skip the tests as they're about to be removed and are low signal/high
noise in presubmits.
@k8s-ci-robot k8s-ci-robot requested review from adisky and dims November 8, 2021 15:21
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 8, 2021
@dims
Copy link
Member

dims commented Nov 8, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, endocrimes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit f20a124 into kubernetes:master Nov 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 8, 2021
@k8s-ci-robot
Copy link
Contributor

@endocrimes: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml

In response to this:

DynamicKubeletConfig is not enabled by default (deprecated) and soon to be removed. Its tests are also incredibly flaky.

As the various changes to the test suite and runner happened, it seems that containerd's presubmits were missed, Rather than enabling the feature gate here, lets skip the tests as they're about to be removed and are low signal/high noise in presubmits.

xref: containerd/containerd#6215
follow up to: #24275

/cc @dims @adisky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@endocrimes endocrimes deleted the dani/fix-containerd branch November 8, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants