Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove DynamicKubeletConfig feature gate from all tests definitions #24284

Conversation

SergeyKanzhelev
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 8, 2021
@SergeyKanzhelev
Copy link
Member Author

/hold

to prevent accidental merge

/cc @endocrimes @cynepco3hahue

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2021
@endocrimes
Copy link
Member

@SergeyKanzhelev We can't remove it from everywhere until we remove Dynamic Kubelet Config tests themselves - until then we have #24276

@endocrimes
Copy link
Member

oh for more context: Unfortunately the DKC tests are badly behaved and fail rather than skipping when the feature gate isn't enabled - unless we explicitly skip them everywhere too, which feels messy.

@SergeyKanzhelev
Copy link
Member Author

@SergeyKanzhelev We can't remove it from everywhere until we remove Dynamic Kubelet Config tests themselves - until then we have #24276

We skip those tests everywhere now.

Sorry for not noticing your PR.

@SergeyKanzhelev SergeyKanzhelev force-pushed the removeDynamicKubeletConfigFeatureGate branch from 54cc022 to 5424fb1 Compare November 8, 2021 19:48
@SergeyKanzhelev
Copy link
Member Author

Rebased after #24276 merged

@cynepco3hahue
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2021
@cynepco3hahue
Copy link

cynepco3hahue commented Nov 9, 2021

@SergeyKanzhelev I can see that we are running DynamicKubelet config tests under our swap lane, probably because I forgot to remove the commit kubernetes/kubernetes@b621165
I will create a PR to revert it, once your PR merged.

@endocrimes
Copy link
Member

/lgtm

combined with kubernetes/kubernetes#106263 this should be safe regardless of extra skipping.

@SergeyKanzhelev
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2021
@endocrimes
Copy link
Member

/lgtm

for containerd approval:
/assign @dims

for releng approval:
/assign @saschagrunert @justaugustus

@dims
Copy link
Member

dims commented Nov 10, 2021

/approve
/lgtm

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold as we're touching releng/test_config.yaml, generated tests may need to be regenerated...

# To generate the test definitions and Prow configurations from this file:
#
# bazel run //releng:generate_tests -- \
# --yaml-config-path=releng/test_config.yaml

When you have a chance, please run:

bazel run //releng:generate_tests -- --yaml-config-path=releng/test_config.yaml

and commit the results with a message similar to:

generated: Run `bazel run //releng:generate_tests`

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 10, 2021
@SergeyKanzhelev
Copy link
Member Author

When you have a chance, please run:

bazel run //releng:generate_tests -- --yaml-config-path=releng/test_config.yaml

Thank you! Took me some time to understand that it wants python2.7. Regenerated

@SergeyKanzhelev
Copy link
Member Author

/retest

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@justaugustus
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@justaugustus
Copy link
Member

/test pull-test-infra-verify-lint

@k8s-ci-robot k8s-ci-robot merged commit 93ae7a9 into kubernetes:master Nov 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd-presubmit-jobs.yaml using file config/jobs/containerd/containerd/containerd-presubmit-jobs.yaml
  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml
  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml
  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Follow up for the kubernetes/kubernetes#105047 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev SergeyKanzhelev deleted the removeDynamicKubeletConfigFeatureGate branch November 15, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants