-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove DynamicKubeletConfig feature gate from all tests definitions #24284
remove DynamicKubeletConfig feature gate from all tests definitions #24284
Conversation
/hold to prevent accidental merge |
@SergeyKanzhelev We can't remove it from everywhere until we remove Dynamic Kubelet Config tests themselves - until then we have #24276 |
oh for more context: Unfortunately the DKC tests are badly behaved and fail rather than skipping when the feature gate isn't enabled - unless we explicitly skip them everywhere too, which feels messy. |
We skip those tests everywhere now. Sorry for not noticing your PR. |
54cc022
to
5424fb1
Compare
Rebased after #24276 merged |
/lgtm |
@SergeyKanzhelev I can see that we are running DynamicKubelet config tests under our swap lane, probably because I forgot to remove the commit kubernetes/kubernetes@b621165 |
/lgtm combined with kubernetes/kubernetes#106263 this should be safe regardless of extra skipping. |
/hold cancel |
/lgtm for containerd approval: for releng approval: |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold as we're touching releng/test_config.yaml
, generated tests may need to be regenerated...
test-infra/releng/test_config.yaml
Lines 15 to 18 in 3d6c14c
# To generate the test definitions and Prow configurations from this file: | |
# | |
# bazel run //releng:generate_tests -- \ | |
# --yaml-config-path=releng/test_config.yaml |
When you have a chance, please run:
bazel run //releng:generate_tests -- --yaml-config-path=releng/test_config.yaml
and commit the results with a message similar to:
generated: Run `bazel run //releng:generate_tests`
Thank you! Took me some time to understand that it wants python2.7. Regenerated |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SergeyKanzhelev!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, justaugustus, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/test pull-test-infra-verify-lint |
@SergeyKanzhelev: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Follow up for the kubernetes/kubernetes#105047 (comment)