Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding node periodic jobs - kubetest2 #24308

Merged
merged 6 commits into from
Nov 17, 2021
Merged

adding node periodic jobs - kubetest2 #24308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d7ac4c
adding job
Namanl2001 Nov 10, 2021
8240ec1
adding command to runner.sh
Namanl2001 Nov 10, 2021
440ef36
adding kubelet kubetest2 job
Namanl2001 Nov 10, 2021
a583e71
remove email-alert
Namanl2001 Nov 12, 2021
930033b
correcting skip regex
Namanl2001 Nov 12, 2021
699e7a3
adding email alert
Namanl2001 Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions config/jobs/kubernetes/sig-node/node-docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,43 @@ periodics:
annotations:
testgrid-dashboards: sig-node-docker
testgrid-tab-name: docker-node-conformance
- name: ci-docker-node-conformance-kubetest2
Namanl2001 marked this conversation as resolved.
Show resolved Hide resolved
interval: 2h
decorate: true
path_alias: k8s.io/kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be replaced with a full ref under extra_refs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- org: kubernetes
  repo: kubernetes
  base_ref: master
  path_alias: k8s.io/kubernetes

extra_refs:
- org: kubernetes
repo: test-infra
base_ref: master
path_alias: k8s.io/test-infra
decoration_config:
timeout: 65m
labels:
preset-service-account: "true"
preset-k8s-ssh: "true"
annotations:
testgrid-dashboards: sig-node-docker
testgrid-tab-name: docker-node-conformance-kubetest2
spec:
containers:
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20211108-d0d3c6d7a8-experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests and limits?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what type of requests and limits are you talking about? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I remember in one of previous PRs I saw the note that requests and limits will be needed on all containers (#24039 (comment)). but I don't know details

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so I didn't add them as there were no requests and limits present in the corresponding non-kubetest2 job.
I also don't know if it's needed.

cc: @ameukam @amwat

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requests and limits are only required for jobs running on k8s-infra-prow-build* (aka field cluster: k8s-infra-prow-build) clusters. They can be added now or when sig-node prowjobs will be migrated to the community-owned infrastructure.

env:
- name: GOPATH
value: /go
command:
- runner.sh
args:
- kubetest2
- noop
- --test=node
- --
- --repo-root=.
- --gcp-zone=us-west1-b
- --parallelism=8
- --focus-regex=\[NodeConformance\]
- --skip-regex=\[Flaky\]|\[Serial\]
- --test-args=--kubelet-flags="--cgroups-per-qos=true --cgroup-root=/"
- --image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/image-config.yaml
- name: ci-docker-node-features
interval: 4h
labels:
Expand Down
49 changes: 49 additions & 0 deletions config/jobs/kubernetes/sig-node/node-kubelet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,55 @@ periodics:
requests:
cpu: 6
memory: 6Gi
- name: ci-kubernetes-node-kubelet-kubetest2
cluster: k8s-infra-prow-build
interval: 1h
decorate: true
path_alias: k8s.io/kubernetes
extra_refs:
- org: kubernetes
repo: test-infra
base_ref: master
path_alias: k8s.io/test-infra
decoration_config:
timeout: 65m
annotations:
fork-per-release: "true"
fork-per-release-periodic-interval: 1h 2h 6h 24h
testgrid-dashboards: sig-release-master-blocking, sig-node-release-blocking
testgrid-tab-name: node-kubelet-master-kubetest2
testgrid-alert-email: kubernetes-sig-node-test-failures@googlegroups.com
description: "Uses kubetest2 to run a subset of node-e2e tests (+NodeConformance, -Flaky|Serial)"
labels:
preset-service-account: "true"
preset-k8s-ssh: "true"
spec:
containers:
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20211108-d0d3c6d7a8-experimental
resources:
limits:
cpu: 6
memory: 6Gi
requests:
cpu: 6
memory: 6Gi
env:
- name: GOPATH
value: /go
command:
- runner.sh
args:
- kubetest2
- noop
- --test=node
- --
- --repo-root=.
- --gcp-zone=us-west1-b
- --parallelism=8
- --focus-regex=\[NodeConformance\]
- --skip-regex=\[Flaky\]|\[Serial\]
- --test-args=--kubelet-flags="--cgroups-per-qos=true --cgroup-root=/"
- --image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/image-config.yaml

- name: ci-kubernetes-node-kubelet-alpha
interval: 1h
Expand Down