Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cluster-api job images to Go 1.17 #24314

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Upgrade cluster-api job images to Go 1.17 #24314

merged 1 commit into from
Nov 11, 2021

Conversation

sbueringer
Copy link
Member

Note: there are no kubekins 1.23 images yet, so I used -master because it contains go 1.17.3

Signed-off-by: Stefan Büringer buringerst@vmware.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 10, 2021
@k8s-ci-robot @sbueringer
Merge pull request kubernetes#24307 from k8s-infra-ci-robot/prowjobs-…
2de5eb3 
…autobump

Update k8s-staging-test-infra images as needed
@sbueringer sbueringer force-pushed the pr-upgrae-capi-jobs-to-go-1.17 branch from 55b62ee to 2de5eb3 Compare November 10, 2021 19:59
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2021
@sbueringer
Copy link
Member Author

/hold
only works together with: kubernetes-sigs/cluster-api#5633

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2021
@sbueringer sbueringer mentioned this pull request Nov 10, 2021
Merged
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @vincepri

vincepri
vincepri approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit ac1c64c into kubernetes:master Nov 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

In response to this:

Note: there are no kubekins 1.23 images yet, so I used -master because it contains go 1.17.3

Signed-off-by: Stefan Büringer buringerst@vmware.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-upgrae-capi-jobs-to-go-1.17 branch November 11, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @vincepri @fabriziopandini