Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add e2e test job for UnvirsionedKubeletConfigMap #24320

Merged
merged 1 commit into from
Nov 11, 2021
Merged

kubeadm: add e2e test job for UnvirsionedKubeletConfigMap #24320

merged 1 commit into from
Nov 11, 2021

Conversation

neolit123
Copy link
Member

Add e2e test job for the new UnvirsionedKubeletConfigMap
feature gate.

needs this to merge first:
kubernetes/kubeadm#2601

xref kubernetes/kubeadm#1582

@neolit123
kubeadm: add e2e test job for UnvirsionedKubeletConfigMap
ca9047e 
Add e2e test job for the new UnvirsionedKubeletConfigMap
feature gate.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2021
@neolit123
Copy link
Member Author

/hold
/sig cluster-lifecycle
/cc @fabriziopandini @SataQiu

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 11, 2021
@neolit123 neolit123 mentioned this pull request Nov 11, 2021
Merged
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 11, 2021
fabriziopandini
fabriziopandini reviewed Nov 11, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit e29ee55 into kubernetes:master Nov 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

@neolit123: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-kinder-unversioned-kubelet-cm.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-unversioned-kubelet-cm.yaml

In response to this:

Add e2e test job for the new UnvirsionedKubeletConfigMap
feature gate.

needs this to merge first:
kubernetes/kubeadm#2601

xref kubernetes/kubeadm#1582

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@SataQiu SataQiu Awaiting requested review from SataQiu

@justinsb justinsb Awaiting requested review from justinsb

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @k8s-ci-robot @fabriziopandini