Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pull-kubernetes-kubemark-e2e-gce-scale to community-owned infrastructure #24353

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Migrate pull-kubernetes-kubemark-e2e-gce-scale to community-owned infrastructure #24353

merged 2 commits into from
Nov 15, 2021

Conversation

marseel
Copy link
Member

@marseel marseel commented Nov 15, 2021 •
edited
Loading

/assign @tosi3k
Fixes #24349

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marseel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 15, 2021
@tosi3k
Copy link
Member

tosi3k commented Nov 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
wojtek-t
wojtek-t reviewed Nov 15, 2021
View reviewed changes
config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml
@@ -393,7 +394,7 @@ presubmits:
- --flush-mem-after-build=true
- --gcp-node-size=e2-standard-8
- --gcp-nodes=84
- --gcp-project=k8s-presubmit-scale
- --gcp-project-type=scalability-project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can scalability-project handle 5k-node kubemark?

Don't we want a different class for those projects?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, scalability-project can handle 5k kubemarks (our kubemark 5k CI already uses this pool).
We don't have different class right now.

@k8s-ci-robot k8s-ci-robot merged commit 683e03c into kubernetes:master Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

@marseel: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml

In response to this:

/assign @tosi3k
Fixes #24349

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@mborsz mborsz Awaiting requested review from mborsz

Assignees

@tosi3k tosi3k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

pull-kubernetes-kubemark-e2e-gce-scale fails when it should not and gathers too little info
4 participants
@marseel @k8s-ci-robot @tosi3k @wojtek-t