Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capdo: add experimental job to use boskos to be able to push temporary container images #24434

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 22, 2021

in order to test the cluster-api api upgrades, we need to push the capdo-controller to the registry and that need to be available to pull.

Looks like we can push temporary images when using boskos (https://kubernetes.slack.com/archives/C09QZ4DQB/p1637516130115600) but not sure

this is needed by the WIP work here kubernetes-sigs/cluster-api-provider-digitalocean#282

/assign @spiffxp

…y container images

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 22, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 886421d into kubernetes:master Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-digitalocean-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-digitalocean/cluster-api-provider-digitalocean-presubmits.yaml

In response to this:

in order to test the cluster-api api upgrades, we need to push the capdo-controller to the registry and that need to be available to pull.

Looks like we can push temporary images when using boskos (https://kubernetes.slack.com/archives/C09QZ4DQB/p1637516130115600) but not sure

this is needed by the WIP work here kubernetes-sigs/cluster-api-provider-digitalocean#282

/assign @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the capdo-experimental branch November 23, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants