Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add kinder test jobs for k8s 1.23 #24442

Merged
merged 1 commit into from
Nov 25, 2021
Merged

kubeadm: add kinder test jobs for k8s 1.23 #24442

merged 1 commit into from
Nov 25, 2021

Conversation

RA489
Copy link
Contributor

@RA489 RA489 commented Nov 23, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 23, 2021
@RA489
Copy link
Contributor Author

RA489 commented Nov 23, 2021

/sig cluster-lifecycle

@RA489
Copy link
Contributor Author

RA489 commented Nov 23, 2021

/assign @neolit123

This was referenced Nov 23, 2021
Merged
Closed
@RA489
Copy link
Contributor Author

RA489 commented Nov 23, 2021

/hold until kubeadm PR merged kubernetes/kubeadm#2611

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2021
@neolit123
Copy link
Member

neolit123 commented Nov 23, 2021 via email

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021
neolit123
neolit123 reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the 1.23 dashboards are up.
https://k8s-testgrid.appspot.com/sig-release

/retest

@RA489
Copy link
Contributor Author

RA489 commented Nov 25, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2021
@RA489
Copy link
Contributor Author

RA489 commented Nov 25, 2021

/test pull-test-infra-bazel
/test pull-test-infra-unit-test

neolit123
neolit123 reviewed Nov 25, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RA489 you should run the update script from kinder again.
(this has merge conflicts now)

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2021
@RA489
Copy link
Contributor Author

RA489 commented Nov 25, 2021 •
edited
Loading

@RA489 you should run the update script from kinder again. (this has merge conflicts now)

merge conflict resolved now. looking for lgtm!

SataQiu
SataQiu approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @RA489

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, RA489, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e4ed938 into kubernetes:master Nov 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Nov 25, 2021
@k8s-ci-robot
Copy link
Contributor

@RA489: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-kinder-discovery.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-discovery.yaml
  • key kubeadm-kinder-external-ca.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-external-ca.yaml
  • key kubeadm-kinder-external-etcd.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-external-etcd.yaml
  • key kubeadm-kinder-kubelet-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-kubelet-x-on-y.yaml
  • key kubeadm-kinder-patches.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-patches.yaml
  • key kubeadm-kinder-upgrade.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-upgrade.yaml
  • key kubeadm-kinder-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-x-on-y.yaml
  • key kubeadm-kinder.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder.yaml

In response to this:

xref kubernetes/kubeadm#2611

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123 neolit123 mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@SataQiu SataQiu SataQiu approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@neolit123 neolit123

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@RA489 @neolit123 @k8s-ci-robot @SataQiu