Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubetest2] adding node-kubelet periodic jobs #24444

Merged
merged 2 commits into from
Nov 28, 2021
Merged

[kubetest2] adding node-kubelet periodic jobs #24444

merged 2 commits into from
Nov 28, 2021

Conversation

Namanl2001
Copy link
Member

This PR is part of the CI migration from kubetest to kubetest2
https://github.com/kubernetes/enhancements/tree/master/keps/sig-testing/2464-kubetest2-ci-migration

added:
ci-kubernetes-node-kubelet-alpha-kubetest2 and
ci-kubernetes-node-kubelet-features-kubetest2

cc: @dims @amwat @SergeyKanzhelev

@Namanl2001
alpha test
6709587 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001
adding kubelet-features
2d9dcd5 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Namanl2001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 23, 2021
Namanl2001
Namanl2001 commented Nov 23, 2021
View reviewed changes
config/jobs/kubernetes/sig-node/node-kubelet.yaml
- --skip-regex=\[Flaky\]|\[Serial\]
- --test-args=--feature-gates=AllAlpha=true,CSIMigration=false,RotateKubeletServerCertificate=false,InTreePluginGCEUnregister=false --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/"
- --image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/image-config.yaml
- --runtime-config=api/all=true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--gcp-project-type and --runtime-config would work after this PR gets merged into kubetest2 [ https://github.com/kubernetes-sigs/kubetest2/pull/175] and once the kubekins image is updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we wait for it? PR is merged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good to go now

Images updated: 70cdbf0

@dims
Copy link
Member

dims commented Nov 28, 2021

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Namanl2001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 88cc1e6 into kubernetes:master Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Nov 28, 2021
@k8s-ci-robot
Copy link
Contributor

@Namanl2001: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

This PR is part of the CI migration from kubetest to kubetest2
https://github.com/kubernetes/enhancements/tree/master/keps/sig-testing/2464-kubetest2-ci-migration

added:
ci-kubernetes-node-kubelet-alpha-kubetest2 and
ci-kubernetes-node-kubelet-features-kubetest2

cc: @dims @amwat @SergeyKanzhelev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Namanl2001 Namanl2001 deleted the perodic branch November 30, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Archived in project
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@Namanl2001 @k8s-ci-robot @dims @SergeyKanzhelev