Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes printing of snyk scan results #24446

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

PushkarJ
Copy link
Member

#24443 added scan result printing which is not needed for debugging purposes. Confirmed this by running locally.

  • Reverting that change but keeping the debug flag
  • Added a comment on why exit 1 is commented for image scanning

/sig security testing
/cc @nehaLohia27 (fyi)
/assign @spiffxp

@k8s-ci-robot k8s-ci-robot added sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2021
- Remove echo of scan results, keeps debug flag
- Adds comment on why exit 1 is commented
@PushkarJ PushkarJ force-pushed the cleanup-scan-script branch from 6373b8d to 31a3c63 Compare November 23, 2021 23:55
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PushkarJ, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0ef1e22 into kubernetes:master Nov 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

@PushkarJ: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-security-trusted.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-security-trusted.yaml

In response to this:

#24443 added scan result printing which is not needed for debugging purposes. Confirmed this by running locally.

  • Reverting that change but keeping the debug flag
  • Added a comment on why exit 1 is commented for image scanning

/sig security testing
/cc @nehaLohia27 (fyi)
/assign @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants