Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 1.23 job updates #24492

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Windows 1.23 job updates #24492

merged 1 commit into from
Nov 30, 2021

Conversation

jsturtevant
Copy link
Contributor

1.23 branch was cut and this does some clean up:

  • adds 1.23 tab for sig-windows
  • adds 1.23 Windows slow job and pre-submits
  • moves the 1.23 job with rest of the windows configs

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 29, 2021
@jsturtevant
Copy link
Contributor Author

/assign @marosset @puerco

@puerco
Copy link
Member

puerco commented Nov 29, 2021

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2021
marosset
marosset approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 724022e into kubernetes:master Nov 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Nov 30, 2021
@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.23-windows-presubmits.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.23-windows-presubmits.yaml
  • key release-1.23-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.23-windows.yaml
  • key 1.23.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.23.yaml

In response to this:

1.23 branch was cut and this does some clean up:

  • adds 1.23 tab for sig-windows
  • adds 1.23 Windows slow job and pre-submits
  • moves the 1.23 job with rest of the windows configs

/sig windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marosset marosset marosset approved these changes

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@puerco puerco

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@jsturtevant @puerco @k8s-ci-robot @marosset