Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkconfig: don't require plugins.yaml for unknown field validation. #24514

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix checkconfig: don't require plugins.yaml for unknown field validation. #24514

merged 1 commit into from
Dec 1, 2021

Conversation

cjwagner
Copy link
Member

@cjwagner cjwagner commented Dec 1, 2021

Oops.
/assign @chaodaiG @mpherman2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, cjwagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aa97daa into kubernetes:master Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 1, 2021
@cjwagner cjwagner deleted the fix-checkconfig-plugin-handling branch December 3, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG chaodaiG approved these changes

@chases2 chases2 Awaiting requested review from chases2

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@chaodaiG chaodaiG

@mpherman2 mpherman2

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@cjwagner @k8s-ci-robot @chaodaiG @mpherman2